[BEAM-9136]support isRelease tag for docker build command & update release guide #11584
Conversation
| buildArgs(['py_version': "2.7", | ||
| 'pull_licenses': project.rootProject.hasProperty(["docker-pull-licenses"])]) | ||
| 'pull_licenses': project.rootProject.hasProperty(["docker-pull-licenses"]) || | ||
| project.rootProject.hasProperty(["isRelease"])]) |
There was a problem hiding this comment.
Currently, the isRelease tag needs to be passed with commands. Ideally, this tag should be set by checking branch name.
Detecting isRelease for docker image build is not that helpful for now, but could be used when we support auto setting isRelease tag.
There was a problem hiding this comment.
I see, thanks. I did not know that we need to set isRelease manually.
| Verify that third party licenses are included by logging in to the images. For Python SDK images, there should be around 80 ~ 100 dependencies. | ||
| Please note that dependencies for the SDKs with different Python versions vary. | ||
| Need to verify all Python images by replacing `${ver}` in the following command to `python2.7, python3.5, python3.6, python3.7`. |
There was a problem hiding this comment.
@ibzib , this part should be verified BEFORE pushing Python images. I'm not sure when this PR can be merged because of website issues, so explicitly pinging you here.
| ``` | ||
| After verifying the third party licenses are included correctly, push the images to DockerHub. | ||
| ``` |
There was a problem hiding this comment.
@ibzib , this part changed slightly. Please note the change from dockerPush to docker at L714.
After creating the Java image, we should verify it BEFORE pushing to DockerHub. I'm not sure when this PR can be merged because of website issues, so explicitly pinging you here.
|
@Hannah-Jiang - you can continue with this change now. However you will need to rebase. |
|
It is rebased. Please take a look when you have time. |
|
Run Python PreCommit |
4 participants
R: @tvalentyn
Cc: @ibzib
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.