[BEAM-10055] Add --region to python examples where it was missing #11779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik-laj
approved these changes
May 22, 2020
epicfaace
suggested changes
May 24, 2020
| # run your pipeline on the Google Cloud Dataflow Service. | ||
| '--project=SET_YOUR_PROJECT_ID_HERE', | ||
| # CHANGE 4/5: Your Google Cloud Storage path is required for staging local | ||
| # CHANGE 4/6: (OPTIONAL) The Google Cloud Engine region is |
Contributor
There was a problem hiding this comment.
See https://cloud.google.com/dataflow/docs/concepts/regional-endpoints
Suggested change
| # CHANGE 4/6: (OPTIONAL) The Google Cloud Engine region is | |
| # CHANGE 4/6: (OPTIONAL) The Google Compute Engine region (such as us-central1) is |
| --test-pipeline-options=" | ||
| --runner=TestDataflowRunner | ||
| --project=... | ||
| --region=... |
Contributor
There was a problem hiding this comment.
Suggested change
| --region=... | |
| --region=... |
aaltay
approved these changes
May 28, 2020
Member
|
retest this please |
Member
|
LGTM. I will merge after tests pass. Thank you @tedromer |
Member
|
retest this please |
1 similar comment
Member
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --region to python examples where it was missing.
R: @ibzib