[BEAM-9987] added instruction for converting maven project to gradle #11964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @angoenka |
Contributor
|
Thanks @JustineKoa ! |
Contributor
|
Thanks @JustineKoa |
Contributor
Author
|
@angoenka Thanks! It is ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions for converting the example WordCount Maven project generated using the generate:archetype into a Gradle project. I've attached images of what it looks like when I run it locally. I don't have much experience writing instructions like this so please let me know if there are any suggestions on how the phrasing/formatting could be better!
Added to setting up development environment:
Instructions:
Instructions for Executing (currently only instructions for runners: Direct, Dataflow, Spark):
View for when a runner is selected that does not have current instructions:
Please let me know if this could be better displayed in an alternate way. If I only include highlight tabs for the ones with current instructions (Direct, Dataflow, and Spark) then the entire runner-switcher under "Run WordCount Using Gradle" disappears if a user clicks on another runner option under "Run WordCount Using Maven". I thought it would make more sense to include the others as placeholders and just mark them as to be added so the whole switcher does not disappear and it's clear where the instruction will be added in the future.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.