Skip to content

[BEAM-10318] fix uninitialized grpc_server in FnApiRunner#12085

Merged
pabloem merged 1 commit intoapache:masterfrom
ihji:BEAM-10318
Jul 1, 2020
Merged

[BEAM-10318] fix uninitialized grpc_server in FnApiRunner#12085
pabloem merged 1 commit intoapache:masterfrom
ihji:BEAM-10318

Conversation

@ihji
Copy link
Contributor

@ihji ihji commented Jun 25, 2020


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark
Go Build Status --- Build Status --- Build Status
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status
XLang --- --- Build Status --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@ihji
Copy link
Contributor Author

ihji commented Jun 25, 2020

R: @chamikaramj

@chamikaramj
Copy link
Contributor

LGTM

@chamikaramj
Copy link
Contributor

Run Python PreCommit

2 similar comments
@chamikaramj
Copy link
Contributor

Run Python PreCommit

@chamikaramj
Copy link
Contributor

Run Python PreCommit

@chamikaramj
Copy link
Contributor

Retest this please

@pabloem
Copy link
Member

pabloem commented Jul 1, 2020

Run Python2_PVR_Flink PreCommit

@pabloem
Copy link
Member

pabloem commented Jul 1, 2020

Run Python PreCommit

@pabloem
Copy link
Member

pabloem commented Jul 1, 2020

Run PythonFormatter PreCommit

@pabloem
Copy link
Member

pabloem commented Jul 1, 2020

Run Python PreCommit

@pabloem
Copy link
Member

pabloem commented Jul 1, 2020

Run PythonFormatter PreCommit

@pabloem pabloem merged commit 05fea6b into apache:master Jul 1, 2020
@ihji ihji deleted the BEAM-10318 branch March 30, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments