Skip to content

Conversation

@lukecwik
Copy link
Member

@lukecwik lukecwik commented Jul 17, 2020

I believe the timeout isn't high enough since on a more powerful machine this test takes almost 3 seconds to run so on a busy jenkins executor it might take longer. Regardless try to use the thread stuckness detector to get more information.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@lukecwik
Copy link
Member Author

R: @apilloud

@lukecwik
Copy link
Member Author

I ran the test 10000 times in a loop without a repro.

Copy link
Member

@apilloud apilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You might look into cpulimit if this comes up again. I've found it really useful for adjusting timeouts that are occasionally triggered on shared testing infrastructure.

@lukecwik
Copy link
Member Author

LGTM.

You might look into cpulimit if this comes up again. I've found it really useful for adjusting timeouts that are occasionally triggered on shared testing infrastructure.

Thanks for the suggestion.

@lukecwik lukecwik merged commit 373859a into apache:master Jul 17, 2020
yirutang pushed a commit to yirutang/beam that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants