Skip to content

Conversation

@coheigea
Copy link
Contributor

There are a couple of instances in the code where toLowerCase().equals() is used, when equalsIgnoreCase() would suffice. The latter is more concise + also doesn't involve the default Locale that's used with toLowerCase(), which might be problematic depending on the String being compared.

@coheigea
Copy link
Contributor Author

@aromanenko-dev

@aromanenko-dev
Copy link
Contributor

Run Spotless PreCommit

@aromanenko-dev aromanenko-dev changed the title BEAM-10668 - Replace toLowerCase().equals() with equalsIgnoreCase [BEAM-10668] Replace toLowerCase().equals() with equalsIgnoreCase Aug 10, 2020
Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@aromanenko-dev aromanenko-dev merged commit 10ccde9 into apache:master Aug 10, 2020
@coheigea coheigea deleted the BEAM-10668 branch August 11, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants