Skip to content

[BEAM-2855] implement query 12#12675

Merged
pabloem merged 1 commit intoapache:masterfrom
leiyiz:nexmark_query_12
Aug 26, 2020
Merged

[BEAM-2855] implement query 12#12675
pabloem merged 1 commit intoapache:masterfrom
leiyiz:nexmark_query_12

Conversation

@leiyiz
Copy link
Contributor

@leiyiz leiyiz commented Aug 24, 2020

implemented query 12, which only runs in streaming mode currently


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels

See CI.md for more information about GitHub Actions CI.

@leiyiz
Copy link
Contributor Author

leiyiz commented Aug 24, 2020

R: @y1chi
R: @pabloem

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #12675 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12675      +/-   ##
==========================================
- Coverage   34.34%   34.32%   -0.03%     
==========================================
  Files         692      695       +3     
  Lines       81948    82234     +286     
  Branches     9263     9295      +32     
==========================================
+ Hits        28144    28225      +81     
- Misses      53381    53586     +205     
  Partials      423      423              
Impacted Files Coverage Δ
io/gcp/bigquery_test.py 27.39% <0.00%> (-0.18%) ⬇️
runners/interactive/interactive_runner.py 30.90% <0.00%> (ø)
testing/benchmarks/nexmark/nexmark_launcher.py 0.00% <0.00%> (ø)
runners/interactive/recording_manager_test.py 28.87% <0.00%> (ø)
runners/interactive/recording_manager.py 30.57% <0.00%> (ø)
testing/benchmarks/nexmark/queries/query12.py 0.00% <0.00%> (ø)
io/gcp/bigquery.py 26.89% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5c5b5...39e74c4. Read the comment docs.

Copy link
Contributor

@y1chi y1chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pabloem
Copy link
Member

pabloem commented Aug 26, 2020

LGTM! Thanks @leiyiz

@pabloem pabloem merged commit 5d8aa2c into apache:master Aug 26, 2020
@leiyiz leiyiz deleted the nexmark_query_12 branch August 26, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants