[BEAM-10701] Add codecov config, fix paths hopefully #12684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it so that "apache_beam" is in the path, and also fix that path to be "sdks/python/apache_beam". Ignore the targets/ directory which has virtualenvs.
Member
Author
|
CC: @SaavanNanavati fingers crossed that this works |
.github/codecov.yml
Outdated
| method: no | ||
| macro: no | ||
|
|
||
| # Do not comment on PRs. |
Member
Author
There was a problem hiding this comment.
It used used to be spammy (1 message per push), but now it seems to be editing the original message so not that bad.
I am reconsidering.
Codecov Report
@@ Coverage Diff @@
## master #12684 +/- ##
==========================================
+ Coverage 34.34% 40.57% +6.23%
==========================================
Files 692 448 -244
Lines 81948 52831 -29117
Branches 9263 0 -9263
==========================================
- Hits 28144 21437 -6707
+ Misses 53374 31394 -21980
+ Partials 430 0 -430 Continue to review full report at Codecov.
|
Member
Author
|
R: @SaavanNanavati (lmk if you have time to review) |
Member
Author
|
also R: @tysonjh |
| extras = test,gcp,interactive,aws | ||
| commands = | ||
| {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" --cov-report=xml:codecov.xml --cov=apache_beam | ||
| {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" --cov-report=xml:codecov.xml --cov=. |
Contributor
|
LGTM I didn't know you could put the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sets up Python code coverage status.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.