[BEAM-10830] Twister2 quickstarts and the runner maven archetypes #12731
Conversation
|
R: @iemejia |
|
@iemejia Sorry about the delay in getting this out. I am not sure what triggers I need to call in order to validate these changes, would you be able to call them or point them out. Thanks in advance |
Codecov Report
@@ Coverage Diff @@
## master #12731 +/- ##
=======================================
Coverage 40.22% 40.22%
=======================================
Files 454 454
Lines 53669 53669
=======================================
Hits 21587 21587
Misses 32082 32082 Continue to review full report at Codecov.
|
|
Run Twister2 ValidatesRunner |
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM Thanks @pulasthi good one to promote use of the runner on new users and validation on releases.
Since the next release will include this please stay tuned in case the release manager may have any issue with the extra validation step (hopefully not).
| import org.apache.beam.sdk.PipelineResult; | ||
| import org.apache.beam.sdk.metrics.MetricResults; | ||
| import org.joda.time.Duration; | ||
| import org.mortbay.log.Log; |
There was a problem hiding this comment.
Is there any particular reason to use a different logger kind here?
We use slf4j in most of the Beam code base for logging so maybe good to follow this on the Twister2 runner. Notice that this can be done in a separate PR.
There was a problem hiding this comment.
@iemejia No, I will create separate PR that encapsulates all the changes you have mentioned. I will remove this log import
| </dependencies> | ||
| </profile> | ||
| <profile> | ||
| <id>twister2-runner</id> |
|
|
||
| /** Check if the Runner is set to use Twister local mode or pointing to a deployment. */ | ||
| private boolean isLocalMode(Twister2PipelineOptions options) { | ||
| if (options.getTwister2Home() == null || "".equals(options.getTwister2Home())) { |
There was a problem hiding this comment.
with guava (use vendor if so) this can be simpler, but that's not blocking at all for this PR
return Strings.isNullOrEmpty(options.getTwister2Home());
2 participants
Adding changes to complete quickstart for Twister2 runner and adding runner maven archetypes
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.