Skip to content

Conversation

@yukihira1992
Copy link
Contributor

@yukihira1992 yukihira1992 commented Sep 21, 2020

Replace deprecated @abstractproperty with @abstractmethod and @property since Python2 is no longer supported.
https://docs.python.org/3/library/abc.html#abc.abstractproperty


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@yukihira1992
Copy link
Contributor Author

R: @robertwb

@yukihira1992 yukihira1992 changed the title [BEAM-10935] Replace @abstractproperty with @abstractmethod and @prop… [BEAM-10935] Replace @abstractproperty with @abstractmethod Sep 21, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #12887 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12887   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files         454      454           
  Lines       54345    54346    +1     
=======================================
+ Hits        44783    44784    +1     
  Misses       9562     9562           
Impacted Files Coverage Δ
sdks/python/apache_beam/io/filesystemio.py 96.82% <100.00%> (+0.02%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 93.38% <0.00%> (-0.74%) ⬇️
sdks/python/apache_beam/transforms/util.py 95.44% <0.00%> (-0.19%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 94.31% <0.00%> (ø)
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.80% <0.00%> (+0.17%) ⬆️
...eam/runners/portability/fn_api_runner/fn_runner.py 89.74% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa58e1e...51592b3. Read the comment docs.

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@robertwb robertwb merged commit 1dc1b33 into apache:master Oct 2, 2020
@yukihira1992 yukihira1992 deleted the beam-10935 branch October 2, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants