[BEAM-11021] Add unsupported BundleFinalizationHandler to portable batch Flink.#13054
[BEAM-11021] Add unsupported BundleFinalizationHandler to portable batch Flink.#13054boyuanzz merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13054 +/- ##
==========================================
- Coverage 82.49% 82.48% -0.01%
==========================================
Files 455 455
Lines 54876 54876
==========================================
- Hits 45270 45266 -4
- Misses 9606 9610 +4
Continue to review full report at Codecov.
|
|
Run Java PreCommit |
mxm
left a comment
There was a problem hiding this comment.
Test failure, but looks good otherwise.
Thanks for the quick approval! The spark unit tests were complaining mocking ambiguous |
|
Run Python_PVR_Flink PreCommit |
2 similar comments
|
Run Python_PVR_Flink PreCommit |
|
Run Python_PVR_Flink PreCommit |
|
Flink test failures are cased by #13014 |
|
Run Python_PVR_Flink PreCommit |
https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Phrase/16/ This is not expected? |
|
Run Python_PVR_Flink PreCommit |
This is not expected. It seems like the test is kind of flaky . |
|
Thanks for your quick review! I'm going to merge this PR. |
This PR added an unsupported BundleFinalizationHandler to portable Flink in batch mode. This will give users a more detailed error message like:
when users try to use bundle finalization in batch.
r: @mxm
cc: @lukecwik @ibzib
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.