[BEAM-11016] Serialize AwsCredentialsProvider for AWS SDK v2 IO connectors #13233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromanenko-dev
changed the title
aromanenko-dev
force-pushed
the
BEAM-11016-SqsIO
branch
from
cc9ae00 to
c27ac40
Compare
aromanenko-dev
changed the title
Contributor
Author
|
R: @iemejia Could you take a look, please? |
aromanenko-dev
force-pushed
the
BEAM-11016-SqsIO
branch
from
c27ac40 to
400bb56
Compare
aromanenko-dev
changed the title
Contributor
Author
|
Run Java PreCommit |
iemejia
approved these changes
Dec 11, 2020
Member
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM Please make it green and self-merge when ready
aromanenko-dev
force-pushed
the
BEAM-11016-SqsIO
branch
from
400bb56 to
bf3c7eb
Compare
Member
|
Merging since it is green now. Thanks Alexey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to serialise
AwsCredentialsProviderfor AWS SDK v2 IO connectors since it's not serialisable and it will be instantiated on workers.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.