[BEAM-11033] Identify Dataflow metrics for portable job path based on step name #13299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… step name. (apache#13298) * Identify Dataflow metrics for portable job path based on step name. * Fixes yapf
Contributor
Author
|
R: @lostluck |
Contributor
|
Run Python PreCommit |
1 similar comment
Contributor
Author
|
Run Python PreCommit |
Contributor
Author
|
Not sure why Python PreCommit keeps failing. But probably unrelated since same test passed for HEAD ? |
Contributor
|
I tend to agree? I'm a little surprised that the python pre-commits contact dataflow... A new worker for this version hasn't been built for Dataflow yet for <reasons I won't get into here>, could that be the cause? |
Contributor
Author
|
Ah yeah, GCE tests will not work without worker containers. |
Contributor
|
Ack. I'll assume that this failure is because of that, and re-evaluate once I've handled the worker builds for dataflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chrry-picks #13298 to 2.26.0 release branch.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.