[BEAM-11219][Website revamp] Development of All about Apache Beam component#13331
Conversation
|
Review: @TheNeuralBit |
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
Thanks @bntnam! A few suggestions
| <path fill="#FF570B" d="M71.084 83.584l7.496.027-.064-7.305c3.041-.061 5.46-2.466 5.437-5.441-.024-2.976-2.49-5.401-5.53-5.49l-.064-7.304-7.495-.027c.025 3.024-2.469 5.46-5.576 5.453-3.106-.013-5.639-2.472-5.67-5.498l-7.496-.027.066 7.3c-3.106-.014-5.602 2.428-5.576 5.452.025 3.024 2.564 5.484 5.67 5.497l.065 7.299 7.496.027c.025 3.024 2.564 5.484 5.67 5.497 3.101.006 5.597-2.436 5.571-5.46z"/> | ||
| <path fill="#fff" d="M52.177 38.556v-7.83h-7.772C44.33 27.553 41.754 25 38.59 25c-3.166 0-5.742 2.553-5.817 5.726H25v7.83c3.215 0 5.823 2.63 5.823 5.871 0 3.242-2.608 5.871-5.823 5.871v7.83h7.766c0 3.243 2.607 5.872 5.823 5.872 3.215 0 5.822-2.63 5.822-5.871h7.766v-7.83c3.216 0 5.823-2.63 5.823-5.872s-2.607-5.87-5.823-5.87z"/> | ||
| <path stroke="#000" stroke-linecap="round" stroke-width="3" d="M84 54l5-3M84.405 62.473l4.192 4.053M86 58.306l7.423.394"/> | ||
| </svg> |
There was a problem hiding this comment.
Is there a reason these files are in assets/icons? It looks like the rest of our images are in static/images
There was a problem hiding this comment.
Yes, the icons in assets/icons can be processed by Hugo Pipes. Thus, instead of using <img src="./images/extensive-icon.svg, I can use {{ $icon := resources.Get "icon/extensive-icon.svg" }}. With that way, I can easily access to svg code and modify it by playing around the $icon.
There was a problem hiding this comment.
Ah neat, thanks for the explanation
| @@ -0,0 +1,10 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" fill="none" viewBox="0 0 32 32"> | |||
There was a problem hiding this comment.
You'll need to add a license header on these files, you can find examples in other .svg files in the repo. How were these images created, are they all original (aside from the youtube/twitter/github icons)?
There was a problem hiding this comment.
Thanks for letting me know. As far as I know, these images are created by our designer.
| body: Execute pipelines on multiple execution environments. | ||
| icon: icons/portable-icon.svg | ||
| - title: Open Source | ||
| body: Use a single programming model for both batch and streaming use cases. |
There was a problem hiding this comment.
Is this a typo? This is the same body as "Unified"
There was a problem hiding this comment.
I was following the design. I believe it's just the text placeholder right now, and the copies will be updated later.
| </a> | ||
| </div> | ||
| <div class="pillars-youtube-icon"> | ||
| <a href="https://www.youtube.com/channel/UChNnb_YO_7B0HlW6FhAXZZQ" target="_blank"> |
There was a problem hiding this comment.
Would it be possible for these to be completely configurable like the main pillars? As it stands the data about each is spread between this file and index.html
There was a problem hiding this comment.
Thanks for your suggestion. I refactored it!
2 participants
Implemented the "All about Apache Beam component"!
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.