[BEAM-11262] Remove numSleeps assertion in SpannerIOWriteTest#13340
Merged
TheNeuralBit merged 1 commit intoapache:masterfrom Nov 17, 2020
Merged
[BEAM-11262] Remove numSleeps assertion in SpannerIOWriteTest#13340TheNeuralBit merged 1 commit intoapache:masterfrom
TheNeuralBit merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
R: @apilloud |
Member
Author
|
Run Java PreCommit |
1 similar comment
Member
|
Run Java PreCommit |
Member
Author
|
Run Java PreCommit |
1 similar comment
Member
Author
|
Run Java PreCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't make an assertion about the number of times the writer slept, this is verifying the backoff policy which is an implementation detail. The test already verifies the total amount of time slept, which is more appropriate.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.