Add use_unified_worker to pipeline options. #13396
Conversation
|
Thanks for the quick review! |
| --bootstrap_servers $BOOTSTRAP_SERVER \ | ||
| --sdk_harness_container_image_overrides ".*java.*,${DOCKER_ROOT}/beam_java8_sdk:latest" \ | ||
| --experiments=use_runner_v2 | ||
| --experiments=use_runner_v2 \ |
There was a problem hiding this comment.
I don't think extra options are needed. Just 'use_runner_v2' should be adequate for Dataflow on runner v2.
cc: @angoenka
There was a problem hiding this comment.
(note that options used for Google internal testing framework may be different. This example is for external usage).
There was a problem hiding this comment.
From my experience, using use_runner_v2 only did give me java runner harness instead of runner v2. We should revisit how these experiments get populated.
There was a problem hiding this comment.
cc: @ananvay
This is surprising. If this is the case something might be broken at HEAD since we ask users to only specify use_runner_v2 to use the C++ worker: https://cloud.google.com/dataflow/docs/guides/deploying-a-pipeline#dataflow-runner-v2
There was a problem hiding this comment.
Not that I'm aware of -- this should still work fine. @angoenka FYI.
There was a problem hiding this comment.
Double checked it with running the cmd again. It seems like I was wrong and am sending out the revert PR: #13446
There was a problem hiding this comment.
Ack, thank you for double-checking Boyuan!
4 participants
use_unified_workeris also needed, otherwise the pipeline will use java runner.r: @aaltay
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.