[BEAM-11360] Updates Dataflow Python multi-language pipelines to use portable job submission by default#13536
Conversation
chamikaramj
force-pushed
the
x-lang_portable_job_submission
branch
from
9540987 to
22483f6
Compare
sdks/python/apache_beam/pipeline.py
Outdated
There was a problem hiding this comment.
Don't we have to do something with external_transform_finder.contains_external_transforms? (Or is this fully redundant with the statement above?)
(IMHO, this visitor pattern is a bit error-prone, perhaps it'd be worth a static method on ExternalTransformFinder that does the visiting and returns a boolean.)
There was a problem hiding this comment.
This was redundant. Updated.
Also, updated the visitor class by adding a static method like you mentioned.
There was a problem hiding this comment.
Just to check, this implies runner v2, right?
There was a problem hiding this comment.
Yes, updated to also include a Runner v2 check.
…submission by default Also cleans up hooks in Python SDK that are not needed when we directly generate Dataflow steps from the Runner API proto.
chamikaramj
force-pushed
the
x-lang_portable_job_submission
branch
from
0b1ab4b to
eb404ad
Compare
There was a problem hiding this comment.
Yes, updated to also include a Runner v2 check.
sdks/python/apache_beam/pipeline.py
Outdated
There was a problem hiding this comment.
This was redundant. Updated.
Also, updated the visitor class by adding a static method like you mentioned.
…portable job submission by default (apache#13536) * Updates Dataflow Python multi-language pipelines to use portable job submission by default Also cleans up hooks in Python SDK that are not needed when we directly generate Dataflow steps from the Runner API proto. * Fixes yapf. * Addresses reviewer comments.
2 participants
Also cleans up multi-language pipelines related hooks in Python SDK that are not needed when we use portable job submission (hence directly generate Dataflow steps from the Runner API proto).
These hooks were mostly were added in PRs #8270 and #11185.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.