Skip to content

[BEAM-11797] Fixed the flaky test#14220

Merged
tvalentyn merged 1 commit intoapache:masterfrom
nika-qubit:BEAM-11797
Mar 12, 2021
Merged

[BEAM-11797] Fixed the flaky test#14220
tvalentyn merged 1 commit intoapache:masterfrom
nika-qubit:BEAM-11797

Conversation

@nika-qubit
Copy link
Contributor

@nika-qubit nika-qubit commented Mar 12, 2021

  1. Fixed the flaky test by explicitly assert_called_with rendered
    HTML/Javascript strings.
  2. The flakiness could be introduced from other display calls emitted
    from the IPythonLogHandler though couldn't reproduce it locally.
    To rule out the flakiness and since assertion at a lower level is
    added, assertion around display is discarded.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

1. Fixed the flaky test by explicitly assert_called_with rendered
   HTML/Javascript strings.
2. The flakiness could be introduced from other display calls emitted
   from the IPythonLogHandler though couldn't reproduce it locally.
   To rule out the flakiness and since assertion at a lower level is
   added, assertion around display is discarded.
@nika-qubit
Copy link
Contributor Author

R: @tvalentyn

PTAL, thx!

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #14220 (e46bd86) into master (adf3dd4) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14220   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files         469      469           
  Lines       58972    58972           
=======================================
+ Hits        49036    49039    +3     
+ Misses       9936     9933    -3     
Impacted Files Coverage Δ
...rcs/sdks/python/apache_beam/runners/direct/util.py
...ers/dataflow/dataflow_exercise_metrics_pipeline.py
...sdks/python/apache_beam/examples/flink/__init__.py
...apache_beam/examples/cookbook/custom_ptransform.py
...s/python/apache_beam/testing/synthetic_pipeline.py
...beam/testing/benchmarks/nexmark/queries/query11.py
...on/apache_beam/runners/portability/flink_runner.py
...x/py38/build/srcs/sdks/python/apache_beam/error.py
.../srcs/sdks/python/apache_beam/utils/sharded_key.py
...d/srcs/sdks/python/apache_beam/metrics/__init__.py
... and 928 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf3dd4...e46bd86. Read the comment docs.

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvalentyn tvalentyn merged commit 0ab785a into apache:master Mar 12, 2021
@nika-qubit nika-qubit deleted the BEAM-11797 branch March 23, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants