Skip to content

Conversation

@iemejia
Copy link
Member

@iemejia iemejia commented Mar 14, 2021

Some minor details I forgot and I realized were not ok after double checking with the generated SNAPSHOTs
R: @ibzib

iemejia added 3 commits March 14, 2021 15:42
…fore

We could call it with a specific version as we do for Spark 3 but this
will break existing clients for a not so important reason.
@iemejia iemejia requested a review from ibzib March 14, 2021 14:53
@iemejia
Copy link
Member Author

iemejia commented Mar 14, 2021

Run Spark ValidatesRunner

@iemejia
Copy link
Member Author

iemejia commented Mar 14, 2021

Run Spark Runner Nexmark Tests

@iemejia
Copy link
Member Author

iemejia commented Mar 14, 2021

Run Java Spark PortableValidatesRunner Batch

@iemejia
Copy link
Member Author

iemejia commented Mar 14, 2021

Run Python Spark ValidatesRunner

@iemejia
Copy link
Member Author

iemejia commented Mar 14, 2021

Run Go Spark ValidatesRunner

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #14228 (1fdf315) into master (153876f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14228      +/-   ##
==========================================
- Coverage   83.17%   83.15%   -0.02%     
==========================================
  Files         469      469              
  Lines       58972    58972              
==========================================
- Hits        49051    49040      -11     
- Misses       9921     9932      +11     
Impacted Files Coverage Δ
...build/srcs/sdks/python/apache_beam/io/snowflake.py
...hon/apache_beam/runners/direct/test_stream_impl.py
...s/snippets/transforms/aggregation/combinevalues.py
...sdks/python/apache_beam/runners/worker/__init__.py
...ks/python/apache_beam/runners/interactive/utils.py
...pache_beam/runners/interactive/caching/__init__.py
...ld/srcs/sdks/python/apache_beam/io/gcp/__init__.py
...dks/python/apache_beam/transforms/create_source.py
...examples/snippets/transforms/elementwise/kvswap.py
.../srcs/sdks/python/apache_beam/dataframe/convert.py
... and 928 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153876f...1fdf315. Read the comment docs.

Copy link

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit 88d687b into apache:master Mar 14, 2021
@iemejia
Copy link
Member Author

iemejia commented Mar 14, 2021

Thanks for the prompt review @ibzib!

@iemejia iemejia deleted the BEAM-7092-spark3-fix-maven-artifact-name branch March 14, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants