-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-7092] Fix artifact names for Spark separated modules + upgrade to Spark 3.1.1 #14228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iemejia
merged 3 commits into
apache:master
from
iemejia:BEAM-7092-spark3-fix-maven-artifact-name
Mar 14, 2021
Merged
[BEAM-7092] Fix artifact names for Spark separated modules + upgrade to Spark 3.1.1 #14228
iemejia
merged 3 commits into
apache:master
from
iemejia:BEAM-7092-spark3-fix-maven-artifact-name
Mar 14, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore We could call it with a specific version as we do for Spark 3 but this will break existing clients for a not so important reason.
Member
Author
|
Run Spark ValidatesRunner |
Member
Author
|
Run Spark Runner Nexmark Tests |
Member
Author
|
Run Java Spark PortableValidatesRunner Batch |
Member
Author
|
Run Python Spark ValidatesRunner |
Member
Author
|
Run Go Spark ValidatesRunner |
ibzib
approved these changes
Mar 14, 2021
ibzib
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
Author
|
Thanks for the prompt review @ibzib! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor details I forgot and I realized were not ok after double checking with the generated SNAPSHOTs
R: @ibzib