Skip to content

Conversation

@pcoet
Copy link
Contributor

@pcoet pcoet commented Jul 29, 2021

Please add a meaningful description for your change here

@aaltay
@tysonjh

This fixes an issue with the language switcher display on the Hadoop page. The JavaScript and CSS are making some assumptions that they shouldn't be making, but I don't think it's worth getting into that right now, since there's a workaround. Feel free to cut a ticket to me if this seems like a problem.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ibzib
Copy link

ibzib commented Jul 29, 2021

It looks like there are potentially a lot more instances of this. https://gist.github.com/ibzib/efaeb9e737a7b96cf034cb5aa2a2b25c

What would we need to do to fix the root cause?

@pcoet
Copy link
Contributor Author

pcoet commented Jul 29, 2021

Ah, okay. Let me look into it some more. The class attributes are not getting set correctly on the snippets without the extra return, which is probably because the DOM tree is a little different for those snippets. The jQuery selector probably needs to be a little more flexible. Will investigate...

@pcoet
Copy link
Contributor Author

pcoet commented Jul 29, 2021

It will be non-trivial to fix the root cause. The Markdown parser is generating extra <p> tags for the newline between highlight shortcodes, and that breaks scripts and CSS. I created another ticket for that root issue: https://issues.apache.org/jira/browse/BEAM-12688 However, I'm not sure that it's even worth fixing. I'll go through the pages and clean them up manually first: https://issues.apache.org/jira/browse/BEAM-12689 In the meantime, I think we should merge this PR.

Copy link

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this further.

LGTM

@aaltay aaltay merged commit 7c2b4b0 into apache:master Jul 30, 2021
@aaltay
Copy link
Member

aaltay commented Jul 30, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants