Use daemon thread to report lull operation and move code to FnApiWork…#15676
Merged
y1chi merged 1 commit intoapache:masterfrom Oct 14, 2021
Merged
Use daemon thread to report lull operation and move code to FnApiWork…#15676y1chi merged 1 commit intoapache:masterfrom
y1chi merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15676 +/- ##
==========================================
- Coverage 83.80% 83.50% -0.31%
==========================================
Files 444 445 +1
Lines 60465 61290 +825
==========================================
+ Hits 50675 51182 +507
- Misses 9790 10108 +318
Continue to review full report at Codecov.
|
6fb8418 to
e4371bb
Compare
Author
|
R: @pabloem |
Author
|
Run Python PreCommit |
Author
|
@pabloem gentle ping for review |
Member
|
LGTM! Thanks @y1chi great improvement |
Member
|
feel free to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…erStatusHandler
Use a deamon thread guarantees that the lull operations are checked with fixed time interval instead of relying on trigger of runner process_bundle_progress request (which may not be happening frequently as needed if no work split is intended).
Code has been moved from sdk worker to the worker status handler since all logic of printing thread dump is also there. Removed full thread dump logging since it is often unreadable in logs plus there are other alternatives to get pretty print full thread dumps such as requesting sdk_status page from runner.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.