Skip to content

Conversation

@rainwoodman
Copy link
Contributor

@rainwoodman rainwoodman commented Dec 1, 2021

The docsting was strongly implying the contract was to create lists, which is not the intention.

GroupByKey returns a Iterable.

@robertwb @katsiapis @dmkozh

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

The docsting was strongly implying the contract was to create lists, which is not the intention.

GroupByKey returns a Iterable.

@robertwb @katsiapis @dmkozh
@rainwoodman
Copy link
Contributor Author

R: @robertwb

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #16099 (e709d39) into master (88429b2) will increase coverage by 37.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #16099       +/-   ##
===========================================
+ Coverage   46.08%   83.65%   +37.56%     
===========================================
  Files         195      447      +252     
  Lines       19457    61692    +42235     
===========================================
+ Hits         8967    51607    +42640     
- Misses       9521    10085      +564     
+ Partials      969        0      -969     
Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/util.py 95.86% <ø> (ø)
sdks/go/pkg/beam/core/graph/bind.go
...dks/go/pkg/beam/core/runtime/harness/monitoring.go
sdks/go/pkg/beam/transforms/top/top.go
sdks/go/pkg/beam/util/gcsx/gcs.go
sdks/go/pkg/beam/core/runtime/exec/plan.go
sdks/go/pkg/beam/core/runtime/exec/window.go
sdks/go/pkg/beam/core/runtime/graphx/user.go
sdks/go/pkg/beam/core/runtime/coderx/varint.go
sdks/go/pkg/beam/transforms/stats/count.go
... and 633 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88429b2...e709d39. Read the comment docs.

@aaltay aaltay requested a review from TheNeuralBit December 11, 2021 04:16
Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TheNeuralBit TheNeuralBit merged commit 75fe1a6 into apache:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants