[BEAM-13247] [Playground] Embedding iframe #16606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded Output/Log TabBar
…anged default ratio of the EmbeddedSplitView
# Conflicts: # playground/frontend/lib/modules/editor/components/editor_textarea.dart # playground/frontend/lib/modules/output/components/output.dart # playground/frontend/lib/modules/output/components/output_area.dart # playground/frontend/lib/modules/output/components/output_header/output_header.dart # playground/frontend/lib/modules/output/components/output_header/output_tabs.dart
…Frame, removed codeScrolling. Added new iFrame on the try-beam-playground page
ElessarST
reviewed
Jan 25, 2022
| ); | ||
|
|
||
| _setTextScrolling(); | ||
| if (!widget.isEmbedded) { |
Contributor
There was a problem hiding this comment.
Maybe it's better to rename it to the enableScrolling, so we can use it in the future on other pages.
There was a problem hiding this comment.
+1, being explicit is much cleaner.
Contributor
Author
There was a problem hiding this comment.
Thank you, renamed this one.
| children: [ | ||
| OutputTabs(tabController: tabController), | ||
| const OutputPlacements(), | ||
| isEmbedded ? const SizedBox() : const OutputPlacements(), |
Contributor
There was a problem hiding this comment.
same here, showOutputPlacements
Contributor
Author
There was a problem hiding this comment.
Renamed this one too.
| PlaygroundState playground, | ||
| PlaygroundState newPlayground, | ||
| ) { | ||
| if (example != null) { |
There was a problem hiding this comment.
Unnest this code block by adding an early return. E.g.
if (example == null) {
return;
}
Contributor
Author
There was a problem hiding this comment.
Hello, @KonradJanica. Thank you for the review, I'll fix that in the next commit.
KonradJanica
approved these changes
Jan 27, 2022
Member
|
thanks all LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new version of the embedded iFrame with:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.