Skip to content

Removes unsupported Python 3.6 from the release validation script#17397

Merged
tvalentyn merged 1 commit intoapache:masterfrom
chamikaramj:remove_3_6_rc_validation
Apr 21, 2022
Merged

Removes unsupported Python 3.6 from the release validation script#17397
tvalentyn merged 1 commit intoapache:masterfrom
chamikaramj:remove_3_6_rc_validation

Conversation

@chamikaramj
Copy link
Contributor

This causes release validation to take an unnecessarily long time and may cause release validation to fail in environments where Python 3.6 is not available.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@chamikaramj
Copy link
Contributor Author

R: @tvalentyn @youngoli

@github-actions github-actions bot added the build label Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #17397 (8cb3e3a) into master (4b709d5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17397      +/-   ##
==========================================
- Coverage   73.76%   73.76%   -0.01%     
==========================================
  Files         686      686              
  Lines       90143    90143              
==========================================
- Hits        66491    66490       -1     
- Misses      22482    22483       +1     
  Partials     1170     1170              
Flag Coverage Δ
python 83.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py 92.68% <0.00%> (-2.44%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 81.09% <0.00%> (-0.73%) ⬇️
...runners/interactive/display/pcoll_visualization.py 85.85% <0.00%> (-0.51%) ⬇️
...eam/runners/interactive/interactive_environment.py 90.21% <0.00%> (-0.31%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.64% <0.00%> (+0.12%) ⬆️
sdks/python/apache_beam/transforms/combiners.py 93.42% <0.00%> (+0.38%) ⬆️
sdks/python/apache_beam/io/localfilesystem.py 92.24% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b709d5...8cb3e3a. Read the comment docs.

@chamikaramj chamikaramj requested a review from tvalentyn April 21, 2022 00:08
@tvalentyn
Copy link
Contributor

Python 3.6 was supported up until last release.
It is being removed in #17252 which will be merged shortly.

@tvalentyn
Copy link
Contributor

cc: @AnandInguva

@tvalentyn tvalentyn merged commit 373c1c9 into apache:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants