Add some typing to prevent speed regression for old_dofn.#1810
Merged
asfgit merged 1 commit intoapache:python-sdkfrom Jan 23, 2017
Merged
Add some typing to prevent speed regression for old_dofn.#1810asfgit merged 1 commit intoapache:python-sdkfrom
asfgit merged 1 commit intoapache:python-sdkfrom
Conversation
Contributor
Author
|
R: @sb2nov |
|
Changes Unknown when pulling f68c9dc on robertwb:new-do-fn into ** on apache:python-sdk**. |
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
LGTM Thanks for this, it might help with the NewDoFn benchmarks too. |
Contributor
|
Just change the title to tag [BEAM-886] before you merge so that the PR is linked to the NewDoFn issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.