Skip to content

Conversation

@pabloem
Copy link
Member

@pabloem pabloem commented Jun 3, 2022

…nline

Following the tips here: https://stackoverflow.com/questions/65986197/difference-between-mockito-core-vs-mockito-inline

Removing extra dep added here: #17753


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Jun 3, 2022
Copy link
Contributor

@ryanthompson591 ryanthompson591 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but will this still fix the build problem with importing mockito in BeamModulePlugin.groovy?

@pabloem
Copy link
Member Author

pabloem commented Jun 3, 2022

hm this seems to definitely have broken something, hah.

@pabloem pabloem closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants