[BEAM-1369] Reduce test sizes to improve unit test speeds#1885
[BEAM-1369] Reduce test sizes to improve unit test speeds#1885sb2nov wants to merge 1 commit intoapache:masterfrom
Conversation
|
R: @chamikaramj - For the io tests especially, is there any value in keeping things larger? |
|
Refer to this link for build results (access rights to CI server needed): |
|
please tag with a JIRA before merging |
sb2nov
changed the title
|
Another related change: #1884 |
|
Let me rebase the PR |
sb2nov
force-pushed
the
BEAM-improve-test-timing
branch
from
442426e to
6aca455
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Let's not reduce the size of test_read_without_splitting_multiple_blocks and test_read_with_splitting_multiple_blocks if they are not too expensive. These tests force Avro library to write multiple blocks without updating block size globally. Reducing size of other tests is fine. |
sb2nov
force-pushed
the
BEAM-improve-test-timing
branch
from
6aca455 to
9a7f5d4
Compare
|
R: @chamikaramj reverted the changes to those two tests. PTAL again. |
| class EstimatePiTransform(beam.PTransform): | ||
| """Runs 10M trials, and combine the results to estimate pi.""" | ||
| def __init__(self, tries_per_work_item=100000): | ||
| self.T = tries_per_work_item |
There was a problem hiding this comment.
Could you change T to something more clear like tries_per_work_item?
sb2nov
force-pushed
the
BEAM-improve-test-timing
branch
from
9a7f5d4 to
a540ad3
Compare
|
Thank you. LGTM. will wait for tests to complete. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
6 participants
R: @aaltay PTAL
These changes reduce the time taken by python unittests from 85 to 36 seconds.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.