[BEAM-1375] Trigger builds on Github push notifications.#1893
[BEAM-1375] Trigger builds on Github push notifications.#1893jasonkuster wants to merge 2 commits intoapache:masterfrom
Conversation
… polling SCM every minute. Signed-off-by: Jason Kuster <jasonkuster@google.com>
|
R: @davorbonaci |
davorbonaci
left a comment
davorbonaci
left a comment
There was a problem hiding this comment.
LGTM. Just a few tiny polish comments.
| static def setPostCommit(def context, | ||
| def build_schedule = '0 */6 * * *', | ||
| def scm_schedule = '* * * * *', | ||
| def poll_github = true, |
| static def setPostCommit(def context, | ||
| def build_schedule = '0 */6 * * *', | ||
| def scm_schedule = '* * * * *', | ||
| def poll_github = true, |
There was a problem hiding this comment.
poll_github -> trigger_every_push
|
|
||
| // Set that this is a PostCommit job. | ||
| // Polls SCM on Feb 31st, i.e. never. | ||
| // Does not poll SCM. |
There was a problem hiding this comment.
Merge these two lines:
This is a post-commit job that runs once per day, not for every push.
.jenkins/job_seed.groovy
Outdated
|
|
||
| // Set that this is a PostCommit job. | ||
| // Polls SCM on Feb 31st, i.e. never. | ||
| // Does not poll SCM. |
|
Changes Unknown when pulling f99e027 on jasonkuster:scm-trigger into ** on apache:master**. |
|
Refer to this link for build results (access rights to CI server needed): |
Signed-off-by: Jason Kuster <jasonkuster@google.com>
|
Addressed comments @davorbonaci PTAL |
|
Refer to this link for build results (access rights to CI server needed): |
davorbonaci
left a comment
davorbonaci
left a comment
There was a problem hiding this comment.
LGTM. I'll merge and should get picked up automatically shortly. Please be on the look-out for any regressions tomorrow.
4 participants
Signed-off-by: Jason Kuster jasonkuster@google.com
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.