Skip to content

[BEAM-886] Migrate from OldDoFn to NewDoFn#1896

Closed
sb2nov wants to merge 1 commit intoapache:masterfrom
sb2nov:BEAM-886-Add-NewDoFn-class-3
Closed

[BEAM-886] Migrate from OldDoFn to NewDoFn#1896
sb2nov wants to merge 1 commit intoapache:masterfrom
sb2nov:BEAM-886-Add-NewDoFn-class-3

Conversation

@sb2nov
Copy link
Contributor

@sb2nov sb2nov commented Feb 2, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

R: @aaltay PTAL

@sb2nov sb2nov changed the title Migrate from OldDoFn to NewDoFn [BEAM-886] Migrate from OldDoFn to NewDoFn Feb 2, 2017
@asfbot
Copy link

asfbot commented Feb 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6983/

Build result: FAILURE

[...truncated 9862 lines...] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoExecutionException: Command execution failed. at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:276) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 moreCaused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404) at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166) at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:660) at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:265) ... 33 more2017-02-02T01:00:30.624 [ERROR] 2017-02-02T01:00:30.624 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-02T01:00:30.624 [ERROR] 2017-02-02T01:00:30.624 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-02T01:00:30.624 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-02-02T01:00:30.625 [ERROR] 2017-02-02T01:00:30.625 [ERROR] After correcting the problems, you can resume the build with the command2017-02-02T01:00:30.625 [ERROR] mvn -rf :beam-sdks-pythonchannel stoppedSetting status of 386f054 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/6983/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@sb2nov sb2nov force-pushed the BEAM-886-Add-NewDoFn-class-3 branch from 386f054 to c09df51 Compare February 2, 2017 19:30
@sb2nov sb2nov changed the title [BEAM-886] Migrate from OldDoFn to NewDoFn [WIP] [BEAM-886] Migrate from OldDoFn to NewDoFn Feb 2, 2017
@asfbot
Copy link

asfbot commented Feb 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7014/

Build result: ABORTED

[...truncated 8258 lines...] ... 31 moreCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/sdks/java/harness && /usr/local/asfpackages/java/jdk1.8.0_102/jre/bin/java org.apache.maven.surefire.booter.ForkedBooter /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/sdks/java/harness/target/surefire/surefire5801899862123791575tmp /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/sdks/java/harness/target/surefire/surefire_168925798852222610443tmp at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) ... 32 more2017-02-02T21:19:53.475 [ERROR] 2017-02-02T21:19:53.475 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-02T21:19:53.475 [ERROR] 2017-02-02T21:19:53.476 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-02T21:19:53.476 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException2017-02-02T21:19:53.476 [ERROR] 2017-02-02T21:19:53.477 [ERROR] After correcting the problems, you can resume the build with the command2017-02-02T21:19:53.477 [ERROR] mvn -rf :beam-sdks-java-harnessBuild was abortedchannel stoppedSetting status of c09df51 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7014/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@sb2nov sb2nov force-pushed the BEAM-886-Add-NewDoFn-class-3 branch 3 times, most recently from 715b283 to cf3993b Compare February 2, 2017 21:54
@sb2nov sb2nov changed the title [WIP] [BEAM-886] Migrate from OldDoFn to NewDoFn [BEAM-886] Migrate from OldDoFn to NewDoFn Feb 2, 2017
@sb2nov
Copy link
Contributor Author

sb2nov commented Feb 2, 2017

R: @aaltay PTAL

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 69.695% when pulling cf3993b on sb2nov:BEAM-886-Add-NewDoFn-class-3 into 70b16c7 on apache:master.

@asfbot
Copy link

asfbot commented Feb 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7029/
--none--

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.691% when pulling cf3993b on sb2nov:BEAM-886-Add-NewDoFn-class-3 into 70b16c7 on apache:master.

@asfbot
Copy link

asfbot commented Feb 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7031/
--none--

@sb2nov sb2nov force-pushed the BEAM-886-Add-NewDoFn-class-3 branch from cf3993b to c71335e Compare February 2, 2017 23:00
Copy link
Member

@aaltay aaltay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this convert all old DoFns?



class FilterTextFn(beam.DoFn):
class FilterTextFn(NewDoFn):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not beam.NewDoFn ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change.

@sb2nov
Copy link
Contributor Author

sb2nov commented Feb 2, 2017

Yes all the DoFns in beam should be migrated after this.

@sb2nov sb2nov force-pushed the BEAM-886-Add-NewDoFn-class-3 branch from c71335e to 3c60178 Compare February 2, 2017 23:45
@aaltay
Copy link
Member

aaltay commented Feb 2, 2017

LGTM

@asfbot
Copy link

asfbot commented Feb 2, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7032/

Build result: ABORTED

[...truncated 8258 lines...] ... 31 moreCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/harness && /usr/local/asfpackages/java/jdk1.8.0_102/jre/bin/java org.apache.maven.surefire.booter.ForkedBooter /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/harness/target/surefire/surefire1835502348022269393tmp /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/harness/target/surefire/surefire_162667360723457275929tmp at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) ... 32 more2017-02-02T23:59:13.894 [ERROR] 2017-02-02T23:59:13.894 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-02T23:59:13.894 [ERROR] 2017-02-02T23:59:13.894 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-02T23:59:13.894 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException2017-02-02T23:59:13.894 [ERROR] 2017-02-02T23:59:13.894 [ERROR] After correcting the problems, you can resume the build with the command2017-02-02T23:59:13.894 [ERROR] mvn -rf :beam-sdks-java-harnessBuild was abortedchannel stoppedSetting status of cf3993b to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7032/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3c60178 on sb2nov:BEAM-886-Add-NewDoFn-class-3 into ** on apache:master**.

@asfbot
Copy link

asfbot commented Feb 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7036/
--none--

@sb2nov
Copy link
Contributor Author

sb2nov commented Feb 3, 2017

Tests passed so should be ready to merge

@asfgit asfgit closed this in c0910fd Feb 3, 2017
@asfbot
Copy link

asfbot commented Feb 3, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7039/

Build result: FAILURE

[...truncated 13408 lines...] ^/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/runners/spark/src/main/java/org/apache/beam/runners/spark/stateful/StateSpecFunctions.java:58: error: reference not found * A helper class that is essentially a {@link Serializable} {@link AbstractFunction3}. ^Command line was: /usr/local/asfpackages/java/jdk1.8.0_102/jre/../bin/javadoc @options @packagesRefer to the generated Javadoc files in '/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/runners/spark/target/apidocs' dir. at org.apache.maven.plugin.javadoc.AbstractJavadocMojo.executeJavadocCommandLine(AbstractJavadocMojo.java:5163) at org.apache.maven.plugin.javadoc.AbstractJavadocMojo.executeReport(AbstractJavadocMojo.java:2075) at org.apache.maven.plugin.javadoc.JavadocJar.execute(JavadocJar.java:188) ... 33 more2017-02-03T00:50:51.145 [ERROR] 2017-02-03T00:50:51.145 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-03T00:50:51.145 [ERROR] 2017-02-03T00:50:51.145 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-03T00:50:51.146 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-02-03T00:50:51.146 [ERROR] 2017-02-03T00:50:51.146 [ERROR] After correcting the problems, you can resume the build with the command2017-02-03T00:50:51.147 [ERROR] mvn -rf :beam-runners-sparkchannel stoppedSetting status of 3c60178 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7039/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@sb2nov sb2nov deleted the BEAM-886-Add-NewDoFn-class-3 branch February 8, 2017 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants