[BEAM-886] Remove the usage of OldDoFn and clean up function names#1917
Merged
asfgit merged 1 commit intoapache:masterfrom Feb 6, 2017
Merged
[BEAM-886] Remove the usage of OldDoFn and clean up function names#1917asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
aaltay
reviewed
Feb 5, 2017
| cdef ScopedMetricsContainer scoped_metrics_container | ||
| cdef list side_inputs | ||
| cdef bint has_windowed_side_inputs | ||
| cdef bint windowed_inputs |
Member
There was a problem hiding this comment.
Name this has_windowed_inputs maybe, because it still a boolean and not a list of inputs.
sb2nov
force-pushed
the
BEAM-886-remove-oldDoFn-6
branch
from
f7208f7 to
e9e4d56
Compare
Contributor
Author
|
Thanks. @aaltay PTAL |
|
Refer to this link for build results (access rights to CI server needed): Build result: ABORTED[...truncated 8343 lines...] ... 31 moreCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/harness && /usr/local/asfpackages/java/jdk1.8.0_102/jre/bin/java org.apache.maven.surefire.booter.ForkedBooter /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/harness/target/surefire/surefire5463691601590839566tmp /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/harness/target/surefire/surefire_162472903609076173860tmp at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) ... 32 more2017-02-05T20:54:40.186 [ERROR] 2017-02-05T20:54:40.186 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-05T20:54:40.186 [ERROR] 2017-02-05T20:54:40.186 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-05T20:54:40.186 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException2017-02-05T20:54:40.187 [ERROR] 2017-02-05T20:54:40.187 [ERROR] After correcting the problems, you can resume the build with the command2017-02-05T20:54:40.187 [ERROR] mvn -rf :beam-sdks-java-harnessBuild was abortedchannel stoppedSetting status of e9e4d56 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7092/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
Contributor
Author
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): Build result: ABORTED[...truncated 8343 lines...] ... 31 moreCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/harness && /usr/local/asfpackages/java/jdk1.8.0_102/jre/bin/java org.apache.maven.surefire.booter.ForkedBooter /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/harness/target/surefire/surefire2508099028197844684tmp /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/harness/target/surefire/surefire_163795127696367831041tmp at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) ... 32 more2017-02-05T23:14:03.821 [ERROR] 2017-02-05T23:14:03.821 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-05T23:14:03.821 [ERROR] 2017-02-05T23:14:03.821 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-05T23:14:03.821 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException2017-02-05T23:14:03.821 [ERROR] 2017-02-05T23:14:03.821 [ERROR] After correcting the problems, you can resume the build with the command2017-02-05T23:14:03.821 [ERROR] mvn -rf :beam-sdks-java-harnessBuild was abortedchannel stoppedSetting status of e9e4d56 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7093/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
Member
|
LGTM. Could you re-run the tests? Let's make sure at least one of them is green. |
sb2nov
force-pushed
the
BEAM-886-remove-oldDoFn-6
branch
from
e9e4d56 to
137d392
Compare
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
R: @aaltay PTAL