Add support repeated template invocations for BQIO.Write#1930
Add support repeated template invocations for BQIO.Write#1930sammcveety wants to merge 1 commit intoapache:masterfrom
Conversation
|
Changes Unknown when pulling c346ae9 on sammcveety:add_side_inputs_to_bigquery_io into ** on apache:master**. |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
R: @dhalperi |
|
Changes Unknown when pulling c346ae9 on sammcveety:add_side_inputs_to_bigquery_io into ** on apache:master**. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Test failures appear unrelated. |
|
R: @tgroh Thomas, can you take a look at this? Very similar to the sharding stuff you did for TextIO.Write, I think. |
tgroh
left a comment
tgroh
left a comment
There was a problem hiding this comment.
Yeah, it's a very similar path.
LGTM
|
Please resolve the merge conflicts, however. |
sammcveety
force-pushed
the
add_side_inputs_to_bigquery_io
branch
from
c346ae9 to
83e286e
Compare
|
Done |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
5 participants
No description provided.