[BEAM-1332] Cleanup files after the tests end#1936
Closed
sb2nov wants to merge 2 commits intoapache:masterfrom
Closed
[BEAM-1332] Cleanup files after the tests end#1936sb2nov wants to merge 2 commits intoapache:masterfrom
sb2nov wants to merge 2 commits intoapache:masterfrom
Conversation
aaltay
reviewed
Feb 7, 2017
| # real data. | ||
| beam.io.ReadFromText = SnippetsTest.DummyReadTransform | ||
| beam.io.WriteToText = SnippetsTest.DummyWriteTransform | ||
| self.files = [] |
Member
There was a problem hiding this comment.
Do you want to call this temp_files? It is fine either way actually.
Member
|
LGTM. Thank you for cleaning this. |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-apex: 1--none-- |
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snippet tests don't clean up the temporary files that are created these changes should address that.
R: @aaltay PTAL
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.