Skip to content

[BEAM-1185] Remove references to PipelineRunner #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sb2nov wants to merge 1 commit into from
Closed

[BEAM-1185] Remove references to PipelineRunner #1955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions sdks/python/apache_beam/runners/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,6 @@ def create_runner(runner_name):
RuntimeError: if an invalid runner name is used.
"""

# TODO(BEAM-1185): Remove when all references to PipelineRunners are gone.
if 'PipelineRunner' in runner_name:
new_runner_name = runner_name.replace('PipelineRunner', 'Runner')
if new_runner_name in _ALL_KNOWN_RUNNERS:
logging.warning(
'%s is deprecated, use %s instead.', runner_name, new_runner_name)
runner_name = new_runner_name

if runner_name in _KNOWN_DIRECT_RUNNERS:
runner_name = 'apache_beam.runners.direct.direct_runner.' + runner_name
elif runner_name in _KNOWN_DATAFLOW_RUNNERS:
Expand Down
6 changes: 0 additions & 6 deletions sdks/python/apache_beam/runners/runner_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,6 @@ def test_create_runner(self):
isinstance(create_runner('TestDataflowRunner'),
TestDataflowRunner))
self.assertRaises(ValueError, create_runner, 'xyz')
# TODO(BEAM-1185): Remove when all references to PipelineRunners are gone.
self.assertTrue(
isinstance(create_runner('DirectPipelineRunner'), DirectRunner))
self.assertTrue(
isinstance(create_runner('DataflowPipelineRunner'),
DataflowRunner))

def test_remote_runner_translation(self):
remote_runner = DataflowRunner()
Expand Down