[BEAM-1471]: Add cross-sdk tests for IterableCoder#1996
[BEAM-1471]: Add cross-sdk tests for IterableCoder#1996asfgit merged 1 commit intoapache:masterfrom vikkyrk:common_iterable_coder
Conversation
| urn: "urn:beam:coders:stream:0.1" | ||
| components: [{urn: "urn:beam:coders:bytes:0.1"}] | ||
| examples: | ||
| "\0\0\0\u0001\u0003abc": ["abc"] |
There was a problem hiding this comment.
I think it will not be generated in many cases, but test for empty iterable?
| .put("urn:beam:coders:bytes:0.1", ByteCoder.class) | ||
| .put("urn:beam:coders:kv:0.1", KvCoder.class) | ||
| .put("urn:beam:coders:varint:0.1", VarLongCoder.class) | ||
| .put("urn:beam:coders:stream:0.1", IterableCoder.class) |
There was a problem hiding this comment.
Suspect you need the asCloudObject-type stuff as in #1984. This will enable the Fn API to recognize the coder.
There was a problem hiding this comment.
This was already added by Luke.
beam/sdks/python/apache_beam/coders/coders.py
Line 584 in d2b8b28
vikkyrk
changed the title
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Changes Unknown when pulling cab5e63 on vikkyrk:common_iterable_coder into ** on apache:master**. |
|
Refer to this link for build results (access rights to CI server needed): |
5 participants
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.