Skip to content

Add Windowing snippets for Python SDK.#2027

Closed
charlesccychen wants to merge 1 commit intoapache:masterfrom
charlesccychen:add-python-snippets
Closed

Add Windowing snippets for Python SDK.#2027
charlesccychen wants to merge 1 commit intoapache:masterfrom
charlesccychen:add-python-snippets

Conversation

@charlesccychen
Copy link
Contributor

No description provided.

@charlesccychen
Copy link
Contributor Author

R: @aaltay

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 69.274% when pulling a6a86c9 on charlesccychen:add-python-snippets into 9151676 on apache:master.

@asfbot
Copy link

asfbot commented Feb 17, 2017


def test_setting_fixed_windows(self):
p = TestPipeline()
unkeyed_items = p | 'create' >> beam.Create([22, 33, 55, 100, 115, 120])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the create label? the transform is already labeled Create.

p.run()

def test_setting_timestamp(self):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove empty line.

@charlesccychen
Copy link
Contributor Author

Thanks, PTAL.

@aaltay
Copy link
Member

aaltay commented Feb 23, 2017

LGTM, thank you.

@asfgit asfgit closed this in 3a8ae53 Feb 23, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ccc0595 on charlesccychen:add-python-snippets into ** on apache:master**.

@asfbot
Copy link

asfbot commented Feb 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7775/
--none--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants