Add Windowing snippets for Python SDK.#2027
Closed
charlesccychen wants to merge 1 commit intoapache:masterfrom
Closed
Add Windowing snippets for Python SDK.#2027charlesccychen wants to merge 1 commit intoapache:masterfrom
charlesccychen wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
R: @aaltay |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-apex: 1--none-- |
aaltay
reviewed
Feb 17, 2017
|
|
||
| def test_setting_fixed_windows(self): | ||
| p = TestPipeline() | ||
| unkeyed_items = p | 'create' >> beam.Create([22, 33, 55, 100, 115, 120]) |
Member
There was a problem hiding this comment.
Should we remove the create label? the transform is already labeled Create.
| p.run() | ||
|
|
||
| def test_setting_timestamp(self): | ||
|
|
a6a86c9 to
ccc0595
Compare
Contributor
Author
|
Thanks, PTAL. |
Member
|
LGTM, thank you. |
|
Changes Unknown when pulling ccc0595 on charlesccychen:add-python-snippets into ** on apache:master**. |
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.