Skip to content

sdks io for cassandra#2113

Closed
surpass wants to merge 9 commits into
apache:masterfrom
surpass:master
Closed

sdks io for cassandra#2113
surpass wants to merge 9 commits into
apache:masterfrom
surpass:master

Conversation

@surpass
Copy link
Copy Markdown

@surpass surpass commented Feb 27, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    `[BEAM-SDKS-IO] cassandra io read and write

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 69.322% when pulling d090294 on surpass:master into b261d48 on apache:master.

@asfbot
Copy link
Copy Markdown

asfbot commented Feb 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7882/
--none--

@jbonofre
Copy link
Copy Markdown
Member

@jbonofre
Copy link
Copy Markdown
Member

I would appreciate you close this PR and contribute directly on the existing one.

@jbonofre
Copy link
Copy Markdown
Member

Thanks !

@davorbonaci
Copy link
Copy Markdown
Member

First, @surpass, thank you for your contribution. It is much appreciated and we'd like to have Cassandra support in Beam as soon as possible!

Indeded, @jbonofre has started this particular effort a while ago, and it would be great if you can work together to move this IO forward as quickly as possible.

Personally, I don't think we need to worry which PR goes first. Perhaps both can go in, in some order, to get a few distinct benefits from each of them.

I'd be happy to assist, as appropriate. Also, CC: @jkff, @dhalperi.

@jbonofre
Copy link
Copy Markdown
Member

jbonofre commented Mar 6, 2017

Original Cassandra PR is almost ready. I would like to merge pretty fast.

<properties>
<cassandra-driver.version>3.1.4</cassandra-driver.version>
<netty.version>4.0.30.Final</netty.version>
<guava.version>16.0.1</guava.version>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is conflicted with default version 20.0, it may breaks.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this just changed in the Java-Driver to support v20: apache/cassandra-java-driver@1ddd09e and https://datastax-oss.atlassian.net/browse/JAVA-1328

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbonofre
Copy link
Copy Markdown
Member

jbonofre commented Mar 8, 2017

As said, I'm resuming/finishing work on #592

@jbonofre
Copy link
Copy Markdown
Member

I just take a quick look to compare with what I did in #592. IMHO, this one is not what we want in Beam: this IO is basically a copy of JdbcIO updated for Cassandra. So basically, no splitting, no leveraging Cassandra features. I would recommend to close this PR and take a look on mine (I'm finalizing #592 this week).

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 70.624% when pulling 4f3543f on surpass:master into 0cba43e on apache:master.

@davorbonaci
Copy link
Copy Markdown
Member

CassandraIO has been merged to Beam from a separate pull request. This pull request is pending closure. Any objections?

@jbonofre
Copy link
Copy Markdown
Member

+1 to close this PR. I asked already some weeks ago.

@jkff
Copy link
Copy Markdown
Contributor

jkff commented Sep 15, 2017

@surpass Could you please close this PR?

Asking in part because I use Github's "Mentioned" PRs tab to keep track of what I need to review, and there is no way for me to remove the PR from there except by asking you to close it.

@jkff jkff closed this Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants