sdks io for cassandra#2113
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
I guess you didn't see: |
|
I would appreciate you close this PR and contribute directly on the existing one. |
|
Thanks ! |
|
First, @surpass, thank you for your contribution. It is much appreciated and we'd like to have Cassandra support in Beam as soon as possible! Indeded, @jbonofre has started this particular effort a while ago, and it would be great if you can work together to move this IO forward as quickly as possible. Personally, I don't think we need to worry which PR goes first. Perhaps both can go in, in some order, to get a few distinct benefits from each of them. I'd be happy to assist, as appropriate. Also, CC: @jkff, @dhalperi. |
|
Original Cassandra PR is almost ready. I would like to merge pretty fast. |
| <properties> | ||
| <cassandra-driver.version>3.1.4</cassandra-driver.version> | ||
| <netty.version>4.0.30.Final</netty.version> | ||
| <guava.version>16.0.1</guava.version> |
There was a problem hiding this comment.
This version is conflicted with default version 20.0, it may breaks.
There was a problem hiding this comment.
FYI this just changed in the Java-Driver to support v20: apache/cassandra-java-driver@1ddd09e and https://datastax-oss.atlassian.net/browse/JAVA-1328
There was a problem hiding this comment.
Netty rev as well: https://github.com/datastax/java-driver/blob/3.1.x/pom.xml#L54
|
As said, I'm resuming/finishing work on #592 |
|
I just take a quick look to compare with what I did in #592. IMHO, this one is not what we want in Beam: this IO is basically a copy of |
|
CassandraIO has been merged to Beam from a separate pull request. This pull request is pending closure. Any objections? |
|
+1 to close this PR. I asked already some weeks ago. |
|
@surpass Could you please close this PR? Asking in part because I use Github's "Mentioned" PRs tab to keep track of what I need to review, and there is no way for me to remove the PR from there except by asking you to close it. |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
`[BEAM-SDKS-IO] cassandra io read and write