[BEAM-1566] Flink: upgrade apache commons#2116
Closed
dhalperi wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-1566] Flink: upgrade apache commons#2116dhalperi wants to merge 1 commit intoapache:masterfrom
dhalperi wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
FWIW, Flink currently depends on 1.4.1: http://mvnrepository.com/artifact/org.apache.flink/flink-core/1.2.0 |
dhalperi
changed the title
Contributor
|
I think this shouldn't be a problem, the dependency was added in Flink to support some additional decompression handlers. A range should be fine. LGTM. |
Contributor
Author
|
Yes and frankly, sdk-java-core should be shading this. |
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @aljoscha
Any concerns about an upgrade here? My understanding is that Apache Commons is good about versioning so this should not be breaking anything.
Prefer an exact version or a range?