Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Jun 6, 2022

  • Python counterpart of existing --defaultSdkHarnessLogLevel pipeline options
    in Java sdk

  • Still need updates from worker side to make it working in DataflowRunner

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 6, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Jun 6, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the python label Jun 6, 2022
@Abacn Abacn marked this pull request as ready for review June 6, 2022 18:47
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #21724 (8847486) into master (b133282) will increase coverage by 0.11%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master   #21724      +/-   ##
==========================================
+ Coverage   74.01%   74.12%   +0.11%     
==========================================
  Files         699      702       +3     
  Lines       92675    93678    +1003     
==========================================
+ Hits        68592    69440     +848     
- Misses      22828    22983     +155     
  Partials     1255     1255              
Flag Coverage Δ
python 83.67% <93.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/runners/worker/logger.py 93.65% <50.00%> (ø)
...dks/python/apache_beam/options/pipeline_options.py 94.95% <100.00%> (+0.01%) ⬆️
...thon/apache_beam/runners/worker/sdk_worker_main.py 75.81% <100.00%> (+1.69%) ⬆️
sdks/python/apache_beam/io/localfilesystem.py 90.97% <0.00%> (-0.76%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.30% <0.00%> (-0.25%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.06% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/io/fileio.py 96.23% <0.00%> (-0.10%) ⬇️
sdks/python/apache_beam/ml/inference/__init__.py 100.00% <0.00%> (ø)
...thon/apache_beam/ml/inference/pytorch_inference.py 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b133282...8847486. Read the comment docs.

@Abacn
Copy link
Contributor Author

Abacn commented Jun 6, 2022

R: @tvalentyn
R: @robertwb

@Abacn
Copy link
Contributor Author

Abacn commented Jun 6, 2022

Was doing BEAM-14147 but apparently this is a blocker. Along with this change still need an update from dataflow worker side to call logger.initialize with the added log_level parameter.

@tvalentyn
Copy link
Contributor

cc: @ryanthompson591

@robertwb
Copy link
Contributor

robertwb commented Jun 7, 2022

The failure at apache_beam.runners.portability.fn_api_runner.fn_runner_test.FnApiRunnerTestWithGrpcAndMultiWorkers.test_pardo_large_inputlooks irrelevant.

@robertwb
Copy link
Contributor

robertwb commented Jun 7, 2022

Run Python PreCommit

@johnjcasey
Copy link
Contributor

LGTM

* Python counterpart of existing --defaultSdkHarnessLogLevel pipeline options
  in Java sdk

* Still need updates from worker side to make it working in DataflowRunner
@Abacn
Copy link
Contributor Author

Abacn commented Jun 15, 2022

rebased due to conflicts of TODO label changes on master

@Abacn
Copy link
Contributor Author

Abacn commented Jun 16, 2022

Run Python PreCommit

@tvalentyn tvalentyn merged commit 79c067c into apache:master Jun 17, 2022
@Abacn Abacn deleted the workerloglevel branch June 17, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants