[BEAM-775] Remove Aggregators from PipelineResults and Examples in Java SDK

[pabloem]

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

• Make sure the PR title is formatted like:
  [BEAM-<Jira issue #>] Description of pull request
• Make sure tests pass via mvn clean verify. (Even better, enable
  Travis-CI on your fork and ensure the whole test matrix passes).
• Replace <Jira issue #> in the title with the actual Jira issue
  number, if there is one.
• If this contribution is large, please file an Apache
  Individual Contributor License Agreement.

---

[pabloem]

r: @bjchambers
I've removed Aggregators from the examples and PipelineResults. I plan to work on removing them from the internal piping in the SDK now.

[coveralls]

Coverage decreased (-0.1%) to 69.923% when pulling 41296b3 on pabloem:remove-agg-java into b45381d on apache:master.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8183/

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-spark: 1

• org.apache.beam.runners.spark.translation.streaming.CreateStreamTest.testDiscardingMode

--none--

[pabloem]

Relaunching tests with PR close/reopen.

[coveralls]

Coverage decreased (-0.1%) to 69.923% when pulling 41296b3 on pabloem:remove-agg-java into b45381d on apache:master.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8191/
--none--

[bjchambers]

live this as "unmatchedWords"

[pabloem]

Done.

[bjchambers]

We may want to keep first refactor the aggregator querying code for use to query metrics, and just convert these tests to metrics?

[pabloem]

You mean keep getAggregatorValues functions, and tests? We may leave as-is and have another PR (right away : )) to add metrics querying and tests. What do you think about that?

[pabloem]

PR 2223 adds querying for metrics.

[coveralls]

Coverage decreased (-0.01%) to 70.041% when pulling 7b7ab3b on pabloem:remove-agg-java into b45381d on apache:master.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8284/
--none--

[coveralls]

Coverage decreased (-0.1%) to 69.989% when pulling 5eecd36 on pabloem:remove-agg-java into 3f0fe91 on apache:master.

[asfbot]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8545/
--none--

[pabloem]

@bjchambers can we get this in and I'll do independent PRs for the other runners?

[davorbonaci]

@pabloem, is there something blocking this PR? If so, it would be good to have a list of those things given that this is blocking the first stable release?

[coveralls]

Coverage decreased (-0.1%) to 70.53% when pulling f603d60 on pabloem:remove-agg-java into 8302783 on apache:master.

[coveralls]

Coverage decreased (-0.1%) to 70.349% when pulling a0d1175 on pabloem:remove-agg-java into eb2e6aa on apache:master.

[pabloem]

@bjchambers can we move forward with this? I can remove the latest commit (Removing Aggregators from PipelineResults and subclasses.) and make that change later, but removing from tests and examples should be okay no?

[coveralls]

Coverage decreased (-0.1%) to 70.11% when pulling 1c4ccc1 on pabloem:remove-agg-java into 6d3fe51 on apache:master.

[coveralls]

Coverage decreased (-0.1%) to 70.0% when pulling 0f75d28 on pabloem:remove-agg-java into 8319369 on apache:master.

[dhalperi]

Fyi, you'll have to rebase this PR to resolve a conflict looks like.

[coveralls]

Coverage decreased (-0.3%) to 69.996% when pulling ba1466b on pabloem:remove-agg-java into b47fd52 on apache:master.

[bjchambers]

Please rebase/squash/clean-up commit message?

[pabloem]

Done. Just need to wait for tests.

[pabloem]

After running mvn clean verify there's nullpointer failures in the Apex runner. I believe these were already happenning?

[bjchambers]

I believe if you remove your ~/.m2 directory you'll get rid of the Apex runner errors.

…

On Mon, Apr 24, 2017, 5:02 PM Pablo ***@***.***> wrote: After running mvn clean verify there's nullpointer failures in the Apex runner. I believe these were already happenning? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2184 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACMeGZkGVcsEE591oJsO3KM3lkdGcfRks5rzTgagaJpZM4MWCkp> .

[coveralls]

Coverage decreased (-0.3%) to 69.731% when pulling 74c2664 on pabloem:remove-agg-java into 7e6f1b7 on apache:master.

[zorro786]

@pabloem I was using Aggregator to keep counter across each InputT bundles. What should be used now? Does Counter work in my case? If so what should be the implementing class of it?

[pabloem]

Hey! Yes, the way to do that now is by using `Metrics.counter`. Gald to help further if you have questions!

On Thu, Jun 7, 2018, 7:18 PM Abdul Qadeer ***@***.***> wrote: @pabloem <https://github.com/pabloem> I was using Aggregator to keep counter across each InputT bundles. What should be used now? Does Counter work in my case? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2184 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPc7M90BseuIpJleYyt1zKUQa0mJanLks5t6d8KgaJpZM4MWCkp> .

-- Got feedback? go/pabloem-feedback

[zorro786]

Thanks. What about calculating mean values?

…

On Thu, 7 Jun 2018 at 21:31, Pablo ***@***.***> wrote: Hey! Yes, the way to do that now is by using `Metrics.counter`. Gald to help further if you have questions! On Thu, Jun 7, 2018, 7:18 PM Abdul Qadeer ***@***.***> wrote: > @pabloem <https://github.com/pabloem> I was using Aggregator to keep > counter across each InputT bundles. What should be used now? Does Counter > work in my case? > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#2184 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/ABPc7M90BseuIpJleYyt1zKUQa0mJanLks5t6d8KgaJpZM4MWCkp > > . > -- Got feedback? go/pabloem-feedback — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2184 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGmMs9Tpe52MuTSNA7dhJUJ_ftfchobmks5t6f4wgaJpZM4MWCkp> .

[pabloem]

For that you can use Metrics.distribution objects, which will track minimum, maximum, count and average.

On Sat, Jun 9, 2018, 12:54 PM Abdul Qadeer ***@***.***> wrote: Thanks. What about calculating mean values? On Thu, 7 Jun 2018 at 21:31, Pablo ***@***.***> wrote: > Hey! Yes, the way to do that now is by using `Metrics.counter`. Gald to > help further if you have questions! > > On Thu, Jun 7, 2018, 7:18 PM Abdul Qadeer ***@***.***> > wrote: > > > @pabloem <https://github.com/pabloem> I was using Aggregator to keep > > counter across each InputT bundles. What should be used now? Does Counter > > work in my case? > > > > — > > You are receiving this because you were mentioned. > > > > > > Reply to this email directly, view it on GitHub > > <#2184 (comment)>, or > mute > > the thread > > < > https://github.com/notifications/unsubscribe-auth/ABPc7M90BseuIpJleYyt1zKUQa0mJanLks5t6d8KgaJpZM4MWCkp > > > > . > > > -- > Got feedback? go/pabloem-feedback <https://goto.google.com/pabloem-feedback> > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#2184 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/AGmMs9Tpe52MuTSNA7dhJUJ_ftfchobmks5t6f4wgaJpZM4MWCkp > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2184 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPc7BbfzRu52PdbK00IHBRgavkCeoq2ks5t7Cf1gaJpZM4MWCkp> .

-- Got feedback? go/pabloem-feedback