Skip to content

[BEAM-775] Remove Aggregators from internal DoFn runner-specific code#2206

Closed
pabloem wants to merge 5 commits intoapache:masterfrom
pabloem:remove-agg-from-runners-java
Closed

[BEAM-775] Remove Aggregators from internal DoFn runner-specific code#2206
pabloem wants to merge 5 commits intoapache:masterfrom
pabloem:remove-agg-from-runners-java

Conversation

@pabloem
Copy link
Member

@pabloem pabloem commented Mar 9, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

This PR depends on PR 2184 being merged first.
An important note is that it changes the signature of some DoFnRunner implementations. This should probably be reviewed by a Spark and Apex runner developers as well.

@pabloem
Copy link
Member Author

pabloem commented Mar 9, 2017

r: @bjchambers

@asfbot
Copy link

asfbot commented Mar 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8233/
--none--

@pabloem pabloem closed this Mar 9, 2017
@pabloem pabloem reopened this Mar 9, 2017
@asfbot
Copy link

asfbot commented Mar 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8238/

Build result: FAILURE

[...truncated 589.80 KB...] ... 61 moreCaused by: java.io.FileNotFoundException: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/.repository/org/apache/ant/ant/1.9.4/ant-1.9.4.jar (No such file or directory) at java.util.zip.ZipFile.open(Native Method) at java.util.zip.ZipFile.(ZipFile.java:219) at java.util.zip.ZipFile.(ZipFile.java:149) at java.util.jar.JarFile.(JarFile.java:166) at java.util.jar.JarFile.(JarFile.java:103) at sun.net.www.protocol.jar.URLJarFile.(URLJarFile.java:93) at sun.net.www.protocol.jar.URLJarFile.getJarFile(URLJarFile.java:69) at sun.net.www.protocol.jar.JarFileFactory.get(JarFileFactory.java:99) at sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.java:122) at org.apache.tools.ant.taskdefs.Antlib.createAntlib(Antlib.java:69) ... 62 more2017-03-09T02:10:59.095 [ERROR] 2017-03-09T02:10:59.095 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-09T02:10:59.095 [ERROR] 2017-03-09T02:10:59.095 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-09T02:10:59.095 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException2017-03-09T02:10:59.095 [ERROR] 2017-03-09T02:10:59.095 [ERROR] After correcting the problems, you can resume the build with the command2017-03-09T02:10:59.095 [ERROR] mvn -rf :beam-runners-core-construction-javachannel stoppedSetting status of e7ae283 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8238/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 86a4692 on pabloem:remove-agg-from-runners-java into ** on apache:master**.

@asfbot
Copy link

asfbot commented Mar 9, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8280/
--none--

@bjchambers
Copy link
Contributor

Could this be split up into multiple, smaller PRs? It would enable faster review/commit cycles. It would also be help to divide them up on runner boundaries, so that it is easier for each runner team to review.

@pabloem
Copy link
Member Author

pabloem commented Mar 14, 2017

Yes. I plan to split this into multiple PRs.

@pabloem pabloem closed this Mar 14, 2017
@pabloem pabloem deleted the remove-agg-from-runners-java branch January 23, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments