-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Minor: Bump flake8 to 4.0.1 #22110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: Bump flake8 to 4.0.1 #22110
Conversation
2f221c1 to
6653b04
Compare
Codecov Report
@@ Coverage Diff @@
## master #22110 +/- ##
==========================================
- Coverage 73.99% 73.99% -0.01%
==========================================
Files 703 703
Lines 92936 92936
==========================================
- Hits 68770 68768 -2
- Misses 22900 22902 +2
Partials 1266 1266
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
For posterity, I added the noga comments with this automation: python -m flake8 --select=E9,F821,F822,F823 apache_beam/**/*.py | cut -d ':' -f 1-2 | sort | uniq | xargs -I {} ./fix_line.sh {}
#!/bin/bash
loc=$1
line=$(echo $loc | cut -d':' -f2-2)
path=$(echo $loc | cut -d':' -f1-1)
sed -i "$line s/$/ # noqa: F821/" $path |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @y1chi for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
y1chi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upgrade flake8 from 3.5.0 to 4.0.1. Also upgrades dependency pycodestyle. This introduces some new
F821 undefined nameerrors for unimported typehints in type comments. f3ef96b3e4f362601968ef2bdf17b61664024880 resovles by addingnoqacomments as needed.GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.