Skip to content

Conversation

@TheNeuralBit
Copy link
Member

@TheNeuralBit TheNeuralBit commented Jun 30, 2022

Upgrade flake8 from 3.5.0 to 4.0.1. Also upgrades dependency pycodestyle. This introduces some new F821 undefined name errors for unimported typehints in type comments. f3ef96b3e4f362601968ef2bdf17b61664024880 resovles by adding noqa comments as needed.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #22110 (6653b04) into master (340b421) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #22110      +/-   ##
==========================================
- Coverage   73.99%   73.99%   -0.01%     
==========================================
  Files         703      703              
  Lines       92936    92936              
==========================================
- Hits        68770    68768       -2     
- Misses      22900    22902       +2     
  Partials     1266     1266              
Flag Coverage Δ
python 83.57% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/dataframe/transforms.py 95.25% <ø> (ø)
...thon/apache_beam/io/azure/blobstoragefilesystem.py 78.21% <ø> (ø)
...s/python/apache_beam/io/gcp/bigquery_avro_tools.py 92.00% <ø> (ø)
...on/apache_beam/runners/dataflow/dataflow_runner.py 83.00% <ø> (ø)
...pache_beam/runners/interactive/interactive_beam.py 81.70% <ø> (ø)
...eam/runners/interactive/options/capture_control.py 100.00% <ø> (ø)
...am/runners/interactive/options/capture_limiters.py 90.76% <ø> (ø)
...ache_beam/runners/interactive/recording_manager.py 96.56% <ø> (ø)
...ks/python/apache_beam/runners/interactive/utils.py 95.06% <ø> (ø)
...ers/portability/fn_api_runner/watermark_manager.py 93.33% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340b421...6653b04. Read the comment docs.

@TheNeuralBit
Copy link
Member Author

For posterity, I added the noga comments with this automation:

python -m flake8 --select=E9,F821,F822,F823 apache_beam/**/*.py | cut -d ':' -f 1-2 | sort | uniq | xargs -I {} ./fix_line.sh {}

./fix_line.sh:

#!/bin/bash

loc=$1

line=$(echo $loc | cut -d':' -f2-2)
path=$(echo $loc | cut -d':' -f1-1)

sed -i "$line s/$/ # noqa: F821/" $path

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @y1chi for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@y1chi y1chi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheNeuralBit TheNeuralBit merged commit b30de9f into apache:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants