Skip to content

Comments

Ensure that assert_that takes a PCollection as its first argument.#2214

Closed
robertwb wants to merge 1 commit intoapache:masterfrom
robertwb:assert-that
Closed

Ensure that assert_that takes a PCollection as its first argument.#2214
robertwb wants to merge 1 commit intoapache:masterfrom
robertwb:assert-that

Conversation

@robertwb
Copy link
Contributor

This can avoid (silent) error such as

with test_pipeline.TestPipeline() as p:
  bad_value = "Create0" >> beam.Create([1])  # Note missing "p | "
  beam_util.assert_that(bad_value, beam_util.equal_to([0]))

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

This can avoid (silent) error such as

    with test_pipeline.TestPipeline() as p:
      bad_value = "Create0" >> beam.Create([1])  # Note missing "p | "
      beam_util.assert_that(bad_value, beam_util.equal_to([0]))
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 70.165% when pulling 479cc01 on robertwb:assert-that into ef256df on apache:master.

@asfbot
Copy link

asfbot commented Mar 10, 2017

@robertwb
Copy link
Contributor Author

retest this please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 70.193% when pulling 479cc01 on robertwb:assert-that into ef256df on apache:master.

@asfbot
Copy link

asfbot commented Mar 16, 2017

@davorbonaci
Copy link
Member

R: @aaltay

@aaltay
Copy link
Member

aaltay commented Mar 20, 2017

LGTM

@asfgit asfgit closed this in 70aa0a4 Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants