Optimize locking in several critical-path methods

[steveniemitz]

This fixes ProxyInvocationHandler.as, DoFnSignatures.getSignature, and ByteBuddyDoFnInvokerFactory.getByteBuddyInvokerConstructor from #22161

The fixes to DoFnSignatures and ByteBuddyDoFnInvokerFactory are trivially changing a Map to ConcurrentHashMap.

ProxyInvocationHandler is more involved, since multiple data structures must be updated atomically on a cache miss. To do this we extract the relevant structures into an immutable class. On a cache miss we construct a new instance of it with new (also immutable) copies of the updated structures. The trade-off here is slightly more garbage creation on a cache miss (since it needs to copy the structures rather than mutate them), however since in steady-state misses ~never occur, and the structures here in question are generally small (~100s of elements).

The impact of these changes is very significant, without these changes my test job spends ~30% of its time in the "start bundle" state, after these changes (as well as ExecutionStateSampler), the % time goes down to ~1-2%.

R: @lukecwik

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[steveniemitz]

Run Java PreCommit

[steveniemitz]

Run Java PreCommit

[steveniemitz]

Run Java PreCommit

[steveniemitz]

Run Java PreCommit

[steveniemitz]

The Pulsar tests are consistently failing again, seems unrelated to this change:

Caused by: java.lang.IllegalArgumentException: Trying to claim offset 1657045837238 before start of the range [1657045838354, 1657045838364)

[lukecwik]

It would be great to add a concurrency test to ensure that things like toString/populateDisplayData/serialize all work when as() is modifying computed properties.

Not sure how easy it will be since you'll need to generate classes at runtime to invoke .as() to.

[lukecwik]

Suggested change

	private final ConcurrentHashMap<String, BoundValue> options;
	/**
	* Enumerating {@code options} must always be done on a copy made before accessing or deriving properties from {@code computedProperties} since concurrent hash maps are <a href="https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/package-summary.html#Weakly>weakly consistent</a>. This will allow us to ensure that the keys in {code options} will always be a subset of properties stored in {code computedProperties}.
	*/
	private final ConcurrentHashMap<String, BoundValue> options;

[steveniemitz]

It would be great to add a concurrency test to ensure that things like toString/populateDisplayData/serialize all work when as() is modifying computed properties.

Not sure how easy it will be since you'll need to generate classes at runtime to invoke .as() to.

Hm, yeah what did you have in mind here? I was struggling to think of anything useful to test.

[lukecwik]

It would be great to add a concurrency test to ensure that things like toString/populateDisplayData/serialize all work when as() is modifying computed properties.
Not sure how easy it will be since you'll need to generate classes at runtime to invoke .as() to.

Hm, yeah what did you have in mind here? I was struggling to think of anything useful to test.

generate new classes in a loop that add a new getter/setter and call .as() and then set the value to a new property. At the same time have another thread in a loop continuously calling toString/populateDisplayData/serialize ensuring that we don't throw an exception.

[steveniemitz]

generate new classes in a loop that add a new getter/setter and call .as() and then set the value to a new property. At the same time have another thread in a loop continuously calling toString/populateDisplayData/serialize ensuring that we don't throw an exception.

Cool, done

[steveniemitz]

Run Java PreCommit

[steveniemitz]

Run Java PreCommit

[steveniemitz]

Run Java PreCommit

[steveniemitz]

Run Java PreCommit