Skip to content

Conversation

@ahmedabu98
Copy link
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

TheNeuralBit and others added 18 commits February 9, 2022 17:29
The GSON object was being initialized in a static context. When the DoFn
that used it was called in another JVM, which did not initialized this
object, we were getting a NPE exception.

Here, we move the initialization of the GSON object inside the DoFn
itself (through a setup method).

Co-authored-by: Thiago Nunes <thiagotnunes@google.com>
…n API. (apache#16852)

The ability to mix and match runners and SDKs is accomplished through two portability layers:
1. The Runner API provides an SDK-and-runner-independent definition of a Beam pipeline
2. The Fn API allows a runner to invoke SDK-specific user-defined functions

Apache Beam pipelines support executing stateful DoFns[1]. To support this execution the Runner API defines multiple user state specifications:
* ReadModifyWriteStateSpec
* BagStateSpec
* OrderedListStateSpec
* CombiningStateSpec
* MapStateSpec
* SetStateSpec

The Fn API[2] defines APIs[3] to get, append and clear user state currently supporting a BagUserState and MultimapUserState protocol.

Since there is no clear mapping between the Runner API and Fn API state specifications, there is no way for a runner to know that it supports a given API necessary to support the execution of the pipeline. The Runner will also have to manage additional runtime metadata associated with which protocol was used for a type of state so that it can successfully manage the state’s lifetime once it can be garbage collected.

Please see the doc[4] for further details and a proposal on how to address this shortcoming.

1: https://beam.apache.org/blog/stateful-processing/
2: https://github.com/apache/beam/blob/3ad05523f4cdf5122fc319276fcb461f768af39d/model/fn-execution/src/main/proto/beam_fn_api.proto#L742
3: https://s.apache.org/beam-fn-state-api-and-bundle-processing
4: http://doc/1ELKTuRTV3C5jt_YoBBwPdsPa5eoXCCOSKQ3GPzZrK7Q
…tefulParDo (apache#16866)

[BEAM-13919] Annotate PerKeyOrderingTest with UsesStatefulParDo.

Co-authored-by: Kyle Weaver <kcweaver@google.com>
…e BQIO to throw an error (apache#16862)

* BEAM-13931 - make sure large rows cause BQIO to throw an error

* prototyping new behavior

* Add test for retryTransients
…nner (apache#16873)

Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
…med f (apache#16886)

Co-authored-by: reuvenlax <relax@google.com>
…ther string or json apache#16890 (apache#16900)

struct.getValue() throws an error when getting a struct that contains
a json inside. We circumvent this, by checking the type and calling
either struct.getString() or struct.getJson().

Co-authored-by: Thiago Nunes <thiagotnunes@google.com>
… to actually limit memory from windmill (apache#16901) (apache#16941)

Currently, because the queue is only limited by number of elements, there can be up to (num threads + queue size) elements outstanding at a time, which for large work items will almost certainly OOM the worker.

This change both makes this limit explicit and adds a 50% JVM max memory limit on outstanding WorkItems to push back on windmill before workers run out of memory.

Co-authored-by: dpcollins-google <40498610+dpcollins-google@users.noreply.github.com>
…apache#16968)

Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>
apache#16969)

Failures to read from Spanner were ignored, and the "ok" serviceCallMwtric was updated before the read took place.

Fix code and tests.

Co-authored-by: Niel Markwick <nielm@users.noreply.github.com>
…pache#16918) (apache#16967)

Co-authored-by: Janek Bevendorff <janek.bevendorff@uni-weimar.de>
…he#17749)

* [BEAM-9351] Upgrade Hive to version 3.1.2

* This eliminated the pentaho dependency

* fix auth issue in test

* Add change log

* move internal test only files to test

* clean up original workaround: Hive 3.1.3 upgraded to log4j 2.17.1
@ahmedabu98
Copy link
Contributor Author

Run PostCommit_Java_Hadoop_Versions

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #22284 (dec46c8) into master (f774585) will increase coverage by 36.81%.
The diff coverage is 36.36%.

@@             Coverage Diff             @@
##           master   #22284       +/-   ##
===========================================
+ Coverage   46.79%   83.60%   +36.81%     
===========================================
  Files         203      452      +249     
  Lines       20044    62277    +42233     
===========================================
+ Hits         9379    52066    +42687     
- Misses       9665    10211      +546     
+ Partials     1000        0     -1000     
Impacted Files Coverage Δ
...thon/apache_beam/io/aws/clients/s3/boto3_client.py 14.39% <12.50%> (ø)
sdks/python/apache_beam/portability/common_urns.py 100.00% <100.00%> (ø)
sdks/python/apache_beam/transforms/userstate.py 84.84% <100.00%> (ø)
sdks/go/pkg/beam/core/runtime/harness/session.go
sdks/go/pkg/beam/core/runtime/exec/hash.go
sdks/go/pkg/beam/core/runtime/genx/genx.go
.../pkg/beam/runners/dataflow/dataflowlib/messages.go
sdks/go/pkg/beam/io/filesystem/local/local.go
sdks/go/pkg/beam/core/graph/graph.go
sdks/go/pkg/beam/impulse.go
... and 648 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f774585...dec46c8. Read the comment docs.

@ahmedabu98 ahmedabu98 closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants