-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Pass getattr calls in AbstractDoFnWrapper to the wrapped dofn for stateful dofns. #22546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
3c15438 to
f3b5c41
Compare
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
…teful dofns.
Otherwise there is an error
```
File "/private/tmp/beam/sdks/python/apache_beam/transforms/userstate.py", line 304, in validate_stateful_dofn
if (timer_spec._attached_callback != getattr(dofn, method_name,
AttributeError: 'NoneType' object has no attribute '__func__'
```
f3b5c41 to
a53b0f4
Compare
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
bump |
|
I will go ahead and review this. I suspect the reviewer you tagged is not active in Beam |
|
Thanks, it was the only choice from https://github.com/apache/beam/blob/master/sdks/python/apache_beam/typehints/OWNERS maybe that should be updated. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
@jonathanasdf Hi sorry, This was slipped from my plate. Is this still relevant? |
Otherwise there is an error
R: @charlesccychen
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.