Skip to content

Conversation

@jonathanasdf
Copy link
Contributor

@jonathanasdf jonathanasdf commented Aug 1, 2022

Otherwise there is an error

  File "/private/tmp/beam/sdks/python/apache_beam/transforms/userstate.py", line 304, in validate_stateful_dofn
    if (timer_spec._attached_callback != getattr(dofn, method_name,
AttributeError: 'NoneType' object has no attribute '__func__'

R: @charlesccychen

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the python label Aug 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jonathanasdf jonathanasdf force-pushed the typecheck-stateful-dofn branch 2 times, most recently from 3c15438 to f3b5c41 Compare August 1, 2022 20:37
@jonathanasdf
Copy link
Contributor Author

R: @charlesccychen

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

…teful dofns.

Otherwise there is an error

```
  File "/private/tmp/beam/sdks/python/apache_beam/transforms/userstate.py", line 304, in validate_stateful_dofn
    if (timer_spec._attached_callback != getattr(dofn, method_name,
AttributeError: 'NoneType' object has no attribute '__func__'
```
@jonathanasdf jonathanasdf force-pushed the typecheck-stateful-dofn branch from f3b5c41 to a53b0f4 Compare August 5, 2022 21:59
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 5, 2022
@jonathanasdf
Copy link
Contributor Author

bump

@AnandInguva
Copy link
Contributor

I will go ahead and review this. I suspect the reviewer you tagged is not active in Beam

@jonathanasdf
Copy link
Contributor Author

Thanks, it was the only choice from https://github.com/apache/beam/blob/master/sdks/python/apache_beam/typehints/OWNERS maybe that should be updated.

@github-actions github-actions bot removed the stale label Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 3, 2023
@github-actions
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Jan 21, 2023
@AnandInguva
Copy link
Contributor

@jonathanasdf Hi sorry, This was slipped from my plate. Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants