Skip to content

[BEAM-547] [BEAM-1730] Cleanup versions.py and root init has version access#2255

Closed
sb2nov wants to merge 1 commit intoapache:masterfrom
sb2nov:BEAM_547-simplify-version-python
Closed

[BEAM-547] [BEAM-1730] Cleanup versions.py and root init has version access#2255
sb2nov wants to merge 1 commit intoapache:masterfrom
sb2nov:BEAM_547-simplify-version-python

Conversation

@sb2nov
Copy link
Copy Markdown
Contributor

@sb2nov sb2nov commented Mar 15, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

R: @aaltay PTAL

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Mar 15, 2017

Do we need version.py after this change?
And can we remove https://github.com/apache/beam/blob/master/sdks/python/MANIFEST.in#L18

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 70.183% when pulling f160325 on sb2nov:BEAM_547-simplify-version-python into 477e789 on apache:master.

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 15, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8474/
--none--

@sb2nov
Copy link
Copy Markdown
Contributor Author

sb2nov commented Mar 15, 2017

We still need versions.py as setup.py calls that script. I'll remove the manifest line

@sb2nov sb2nov force-pushed the BEAM_547-simplify-version-python branch from f160325 to 9a021b6 Compare March 15, 2017 23:15
@sb2nov
Copy link
Copy Markdown
Contributor Author

sb2nov commented Mar 15, 2017

R: @aaltay PTAL

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.003%) to 70.18% when pulling 9a021b6 on sb2nov:BEAM_547-simplify-version-python into 004d307 on apache:master.

@asfbot
Copy link
Copy Markdown

asfbot commented Mar 15, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8478/
--none--

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Mar 16, 2017

LGTM. Thank you.

@asfgit asfgit closed this in 444edae Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants