Skip to content

Fix shading opt out in io/google-cloud-platform#2259

Merged
asfgit merged 1 commit intoapache:masterfrom
aviemzur:fix-google-io-shading-opt-out
Mar 16, 2017
Merged

Fix shading opt out in io/google-cloud-platform#2259
asfgit merged 1 commit intoapache:masterfrom
aviemzur:fix-google-io-shading-opt-out

Conversation

@aviemzur
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@asfbot
Copy link

asfbot commented Mar 16, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8486/
--none--

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling dd1b001 on aviemzur:fix-google-io-shading-opt-out into ** on apache:master**.

@aviemzur
Copy link
Member Author

aviemzur commented Mar 16, 2017

R: @amitsela
This is a fix for broken master build.

Looks like the opt-out instructions in PR #2096 (comment) were faulty and caused master to break.
I've since edited the comment with a correct version which is the one in this PR.

@amitsela
Copy link
Member

LGTM

@asfgit asfgit merged commit dd1b001 into apache:master Mar 16, 2017
asfgit pushed a commit that referenced this pull request Mar 16, 2017
@aviemzur aviemzur deleted the fix-google-io-shading-opt-out branch March 28, 2017 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants