Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Aug 11, 2022

Per infra we can just let the system do chain based auth here and so we don't need to explicitly supply a cert file.

This fixes the issue and adds some logging

Fixes #22676


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

Run seed job

@github-actions github-actions bot added the infra label Aug 11, 2022
@damccorm
Copy link
Contributor Author

Run seed job

@damccorm
Copy link
Contributor Author

Run seed job

@damccorm
Copy link
Contributor Author

Run seed job

@damccorm
Copy link
Contributor Author

Run seed job

@damccorm damccorm changed the title Dont merge: Test - figure out if seed job is picking up changes Fix seed job Aug 11, 2022
@damccorm damccorm marked this pull request as ready for review August 11, 2022 15:37
@damccorm
Copy link
Contributor Author

R: @TheNeuralBit

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. It's fun when a negative diff solves a problem :)

@damccorm damccorm merged commit cf8e060 into master Aug 11, 2022
@damccorm damccorm deleted the users/damccorm/loggingLDAP branch August 11, 2022 16:23
MarcoRob pushed a commit to MarcoRob/beam that referenced this pull request Sep 5, 2022
* Dont merge: Test - figure out if seed job is picking up changes

* Update main.py

* Log all args

* Try removing cert option

* Delete cert.pem

* Remove cert related things
kileys pushed a commit to kileys/beam that referenced this pull request Oct 25, 2022
* Dont merge: Test - figure out if seed job is picking up changes

* Update main.py

* Log all args

* Try removing cert option

* Delete cert.pem

* Remove cert related things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Seed job failing to access LDAP

2 participants