-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix seed job #22687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix seed job #22687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Run seed job |
Contributor
Author
|
Run seed job |
Contributor
Author
|
Run seed job |
Contributor
Author
|
Run seed job |
Contributor
Author
|
Run seed job |
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
TheNeuralBit
approved these changes
Aug 11, 2022
Member
TheNeuralBit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks. It's fun when a negative diff solves a problem :)
MarcoRob
pushed a commit
to MarcoRob/beam
that referenced
this pull request
Sep 5, 2022
* Dont merge: Test - figure out if seed job is picking up changes * Update main.py * Log all args * Try removing cert option * Delete cert.pem * Remove cert related things
kileys
pushed a commit
to kileys/beam
that referenced
this pull request
Oct 25, 2022
* Dont merge: Test - figure out if seed job is picking up changes * Update main.py * Log all args * Try removing cert option * Delete cert.pem * Remove cert related things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per infra we can just let the system do chain based auth here and so we don't need to explicitly supply a cert file.
This fixes the issue and adds some logging
Fixes #22676
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.