Skip to content

[BEAM-1306] Refactors BigQueryServices interface to allow the client to set options#2282

Closed
g-eorge wants to merge 1 commit intoapache:masterfrom
g-eorge:BEAM-1306-refactor-bigqueryservices
Closed

[BEAM-1306] Refactors BigQueryServices interface to allow the client to set options#2282
g-eorge wants to merge 1 commit intoapache:masterfrom
g-eorge:BEAM-1306-refactor-bigqueryservices

Conversation

@g-eorge
Copy link

@g-eorge g-eorge commented Mar 21, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@asfbot
Copy link

asfbot commented Mar 21, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8626/

Build result: FAILURE

[...truncated 974.67 KB...] at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:83) at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:77) at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:60) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:235) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:247) at org.codehaus.mojo.findbugs.FindbugsViolationCheckMojo.execute(FindbugsViolationCheckMojo.groovy:529) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-03-21T12:05:42.611 [ERROR] 2017-03-21T12:05:42.611 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-21T12:05:42.611 [ERROR] 2017-03-21T12:05:42.611 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-21T12:05:42.611 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-03-21T12:05:42.612 [ERROR] 2017-03-21T12:05:42.612 [ERROR] After correcting the problems, you can resume the build with the command2017-03-21T12:05:42.612 [ERROR] mvn -rf :beam-sdks-java-io-google-cloud-platformchannel stoppedSetting status of f097d3b to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8626/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@dhalperi
Copy link
Contributor

R: @peihe

@tkaymak
Copy link
Contributor

tkaymak commented Mar 29, 2017

Any news on this one?

@reuvenlax
Copy link
Contributor

Can you explain how the user will specify these options?

@asfbot
Copy link

asfbot commented Apr 8, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9319/

Build result: FAILURE

[...truncated 738.45 KB...] at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:83) at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:77) at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:60) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:235) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:247) at org.codehaus.mojo.findbugs.FindbugsViolationCheckMojo.execute(FindbugsViolationCheckMojo.groovy:529) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-04-08T16:31:44.304 [ERROR] 2017-04-08T16:31:44.304 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-04-08T16:31:44.304 [ERROR] 2017-04-08T16:31:44.304 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-04-08T16:31:44.304 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-04-08T16:31:44.305 [ERROR] 2017-04-08T16:31:44.305 [ERROR] After correcting the problems, you can resume the build with the command2017-04-08T16:31:44.305 [ERROR] mvn -rf :beam-sdks-java-io-google-cloud-platformchannel stoppedSetting status of f097d3b to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9319/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@g-eorge
Copy link
Author

g-eorge commented Apr 8, 2017

@reuvenlax the user will be able to set options like .withoutValidation() on the pipeline. #1778 illustrates the idea, and will be refactored slightly once this one is resolved so that for streaming writes the options don't need to be passed around.

@davorbonaci
Copy link
Member

R: @reuvenlax -@peihe

@davorbonaci
Copy link
Member

@reuvenlax, any thoughts perhaps?

@aaltay
Copy link
Member

aaltay commented Jun 8, 2017

@reuvenlax any thoughts on this PR?

@reuvenlax
Copy link
Contributor

This PR needs to be rebased - the underlying BigQuery codebase has changed quite a bit underneat it.

@davorbonaci
Copy link
Member

Hi @g-eorge, would you like to push this pull request forward? Please let us know if we can assist somehow.

@reuvenlax
Copy link
Contributor

The underlying transforms have changed quite a bit, so this PR would need to be rebased.

@jkff
Copy link
Contributor

jkff commented Dec 16, 2017

Is this PR still active or should it be closed?

@dhalperi
Copy link
Contributor

Suggest closure.


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@jkff jkff closed this Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments