Skip to content

Comments

Flag fix.#2283

Closed
jasonkuster wants to merge 2 commits intoapache:masterfrom
jasonkuster:patch-2
Closed

Flag fix.#2283
jasonkuster wants to merge 2 commits intoapache:masterfrom
jasonkuster:patch-2

Conversation

@jasonkuster
Copy link
Contributor

Changed this flag as a result of review -- have to update here. This will cease to be a problem once we land in PKB mainline.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

R: @tgroh

Changed this flag as a result of review -- have to update here. This will cease to be a problem once we land in PKB mainline.
@jasonkuster
Copy link
Contributor Author

Run Seed Job

@asfbot
Copy link

asfbot commented Mar 21, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_SeedJob/176/
--none--

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 70.155% when pulling a81b4f5 on jasonkuster:patch-2 into f785584 on apache:master.

@asfbot
Copy link

asfbot commented Mar 21, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8627/
--none--

@tgroh
Copy link
Member

tgroh commented Mar 21, 2017

LGTM, assuming infrastructure agrees.

Will merge on https://builds.apache.org/job/beam_PerformanceTests_JDBC/15/ success

Signed-off-by: Jason Kuster <jasonkuster@google.com>
@jasonkuster
Copy link
Contributor Author

Run Seed Job

@asfbot
Copy link

asfbot commented Mar 21, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_SeedJob/177/
--none--

@tgroh
Copy link
Member

tgroh commented Mar 21, 2017

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.162% when pulling 4570390 on jasonkuster:patch-2 into f785584 on apache:master.

@tgroh
Copy link
Member

tgroh commented Mar 21, 2017

@asfbot
Copy link

asfbot commented Mar 21, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8629/
--none--

@asfgit asfgit closed this in 0895ec1 Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants